Skip to content

Commit 5b13d99

Browse files
Revert "[Clang] Enable lit internal shell by default"
This reverts commit 25e218d. This is causing errors on the llvm-clang-aarch64-darwin builder related to too many files being open.
1 parent 354ad55 commit 5b13d99

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

clang/test/lit.cfg.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,11 @@
1818
# name: The name of this test suite.
1919
config.name = "Clang"
2020

21-
# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites.
22-
# See https://github.com/llvm/llvm-project/issues/106636 for more details.
23-
#
24-
# We prefer the lit internal shell which provides a better user experience on failures
25-
# and is faster unless the user explicitly disables it with LIT_USE_INTERNAL_SHELL=0
26-
# env var.
27-
use_lit_shell = True
28-
lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
29-
if lit_shell_env:
30-
use_lit_shell = lit.util.pythonize_bool(lit_shell_env)
31-
3221
# testFormat: The test format to use to interpret tests.
3322
#
3423
# For now we require '&&' between commands, until they get globally killed and
3524
# the test runner updated.
36-
config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell)
25+
config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
3726

3827
# suffixes: A list of file extensions to treat as test files.
3928
config.suffixes = [

0 commit comments

Comments
 (0)