Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sethome not support áéíőúűáéóüö characters #1742

Open
andris155 opened this issue Jan 2, 2018 · 4 comments · May be fixed by #5861
Open

The sethome not support áéíőúűáéóüö characters #1742

andris155 opened this issue Jan 2, 2018 · 4 comments · May be fixed by #5861
Labels
status: open to PR Low priority enhancements that anyone is welcome to contribute. type: enhancement Features and feature requests.

Comments

@andris155
Copy link

EssentialsX version (run /essentials):
2.0.1-b557

Server software (run /version):
This server is running Paper version git-Paper-1272 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

Server (logs/latest.log):
I send if need.

EssentialsX config (plugins/Essentials/config.yml):
I send if need.

Details:
sethome not support áéíőúűáéóüö characters
/sethome ház (ház -> h_z)
@DrewAMitchell
Copy link
Contributor

Are you saying that it takes accented/umlauted characters and turns them to underscores?
Does this show up as so in the user's data file?
Now, I'm not familiar with what language you're likely using, but I figure that in most languages, you can go without the accents/umlauts, however incorrect. With that being said, I also am not entirely sure how easy it would be to implement support for these characters, I believe the files would just need to be encoded in UTF8 if they're not.
Just my initial input to get some info out of you!

@mdcfe
Copy link
Member

mdcfe commented Jan 2, 2018

Replacing the diacritics with underscores is intentional; without this, the YAML would break when reloading the user's data. The only way to work around this is to not add the diacritics and just type the undecorated vowels.

@mdcfe mdcfe closed this as completed Jan 2, 2018
@andris155 andris155 mentioned this issue Jan 3, 2018
Closed
@mcnagynorbi
Copy link

Replacing the diacritics with underscores is intentional; without this, the YAML would break when reloading the user's data. The only way to work around this is to not add the diacritics and just type the undecorated vowels.

Hello!

After five (almost six) years we have talked about this on discord and you said:

It's likely possible to support accented characters now since we do save the contents of configs in UTF-8 - leave a comment on the original issue and we can revisit it

So here I am - hoping that it could be solved.

It would be so much better for the users we would be so happy.
Thanks.

@mdcfe mdcfe added type: enhancement Features and feature requests. status: open to PR Low priority enhancements that anyone is welcome to contribute. labels Dec 6, 2023
@mdcfe
Copy link
Member

mdcfe commented Dec 6, 2023

Reopening as a feature request, since we should now be safe to store home names as UTF-8

@mdcfe mdcfe reopened this Dec 6, 2023
zp4rker added a commit to zp4rker/Essentials that referenced this issue Jul 4, 2024
@zp4rker
Allow unicode characters as userdata file is now written in UTF-8
1e2b3f1 
Fixes EssentialsX#1742
@zp4rker zp4rker linked a pull request Jul 4, 2024 that will close this issue
Open
3 tasks
@Evidentsinger14 Evidentsinger14 mentioned this issue Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: open to PR Low priority enhancements that anyone is welcome to contribute. type: enhancement Features and feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow unicode characters as userdata file is now written in UTF-8 zp4rker/Essentials
4 participants
@mdcfe @DrewAMitchell @andris155 @mcnagynorbi