Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed The "Code distortion in History Tab and Created Detailed History Pop-up Page #450

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MastanSayyad
Copy link
Contributor

Hey @EternoSeeker

I have fixed the distorted code from the history tab, then I noticed that there is no page/pop-up for the History tab
So I have:

  • Created a new History Pop Up
  • Added detailed information about the pop-ups
  • created tables to showcase the details in a more organized manner
  • Adjust the sizes and alignments of the content
  • On clicking the history tab opens a history pop-up model
  • Made it complete responsive

image

Created new images:

  • Glider, Oscillator, Spaceships, Gun
Image 1 Image 2 Image 3 Image 4

image

image

Overall Screen Record

09.08.2024_04.35.48_REC.mp4

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Please take a look and review it!
If Possible please add or increase the gssoc level for this PR considering the changes

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for eternalgameoflife ready!

Name Link
🔨 Latest commit c20d41e
🔍 Latest deploy log https://app.netlify.com/sites/eternalgameoflife/deploys/66b55053212b790008ce846c
😎 Deploy Preview https://deploy-preview-450--eternalgameoflife.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EternoSeeker
Copy link
Owner

Screenshot 2024-08-09 213105
History section is to store user history after he plays his pattern
we store the pattern after each play and most recent one is displayed first up to 5 patterns, that was the purpose of history section, and it wasn't working ig. That was the issue

@EternoSeeker
Copy link
Owner

EternoSeeker commented Aug 9, 2024

I appreciate what you did here, maybe we can add some of these details in game rules popup, and try to fix the history section to it's intended functionality

@MastanSayyad
Copy link
Contributor Author

@EternoSeeker Oh I'm really sorry for the oversight! I didn't knew about The history button functionality, as on click It was empty, I will add the details in gamerules page (as the game rule pop will become too lengthy ) and try to fix the history button functionality!

@EternoSeeker
Copy link
Owner

yea, sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG in History tab: Code distortion
2 participants