Skip to content

Clean Processor::runJob() and runScheduledJob() #109

@kyriog

Description

@kyriog

The \EthanYehuda\CronjobManager\Helper\Processor::runJob() method has 99% the same code of Processor::runScheduledJob().

The only difference between these two methods is when the schedule object is saved:
runJob() directly call the save() method of the schedule object itself (which is deprecated according to Magento 2 best practices) whereas runScheduledJob() runs the save() method from the object getResource().

I think runJob() should be deleted if possible, or at least being updated as deprecated and pointing to runScheduledJob() method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions