You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
thus giving SceneCanvas two different values for show, raising an error.
A simple fix is to put show=True in the SceneObj init , then modify the call to create a SceneCanvas object to pass in show=show.
I'm not putting this in a PR because, while the suggested modification is consistent with the docstring, it changes the default behaviour. To replicate the current behaviour, the SceneObj init should have show=False (and the docstring should be updated accordingly). I'm not sure what the "correct" desired behaviour is.
The text was updated successfully, but these errors were encountered:
SceneObj's docstring lists
show
as a kwarg:visbrain/visbrain/objects/scene_obj.py
Lines 339 to 347 in b599038
However, it isn't an explicit kwarg in the constructor
visbrain/visbrain/objects/scene_obj.py
Lines 361 to 362 in b599038
so it gets dumped into
kwargs
.**kwargs
is then passed on to theSceneCanvas
constructor, which also has an explicitshow=False
,visbrain/visbrain/objects/scene_obj.py
Lines 368 to 370 in b599038
thus giving
SceneCanvas
two different values forshow
, raising an error.A simple fix is to put
show=True
in the SceneObj init , then modify the call to create aSceneCanvas
object to pass inshow=show
.I'm not putting this in a PR because, while the suggested modification is consistent with the docstring, it changes the default behaviour. To replicate the current behaviour, the
SceneObj
init should haveshow=False
(and the docstring should be updated accordingly). I'm not sure what the "correct" desired behaviour is.The text was updated successfully, but these errors were encountered: