Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to define the endstop pin for gear_stepper #124

Closed
eamars opened this issue Jul 22, 2022 · 1 comment
Closed

Remove the need to define the endstop pin for gear_stepper #124

eamars opened this issue Jul 22, 2022 · 1 comment

Comments

@eamars
Copy link
Contributor

eamars commented Jul 22, 2022

I'm not sure the original intention and purpose of defining the endstop_pin for the gear_stepper. As of today (klipper 0.10.526), a slight modification to the code can remove the requirement to define the non-exist endstop_pin by

Replacing
self.gear_stepper.rail.steppers[0]

with
self.gear_stepper.rail

Pleaset let me know if that's a good idea. Otherwise I can create a PR for this change.

@eamars
Copy link
Contributor Author

eamars commented Aug 4, 2022

Just realized there is already an PR raised. #100

@eamars eamars closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant