Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake doesn't check for ruamel.yaml Python Module #48

Open
bpadalino opened this issue Oct 8, 2020 · 0 comments
Open

CMake doesn't check for ruamel.yaml Python Module #48

bpadalino opened this issue Oct 8, 2020 · 0 comments

Comments

@bpadalino
Copy link
Contributor

CMake doesn't check if the ruamel.yaml Python module is installed. UHD checks for it in the following way:

set(RUAMEL.YAML_MIN_VERSION "0.15")
PYTHON_CHECK_MODULE(
    "ruamel.yaml ${RUAMEL.YAML_MIN_VERSION} or greater"
    "ruamel.yaml" "LooseVersion(ruamel.yaml.__version__) >= LooseVersion('${RUAMEL.YAML_MIN_VERSION}')"
    HAVE_PYTHON_MODULE_YAML
)

Where PYTHON_CHECK_MODULE comes from UHDPython.cmake which isn't installed with UHD, but comes from UHD.

In some test files (python_api_test.py and uhd_test_base.py), UHD does the following:

try:
    from ruamel import yaml
except:
    import yaml

Is the ruamel.yaml Python module really required, or is it just nice to have? Can the try/except import work for this dependency? If not, should UHDPython.cmake be installed by UHD, or should the macro just come over to this repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant