Skip to content

Commit 36e8921

Browse files
committed
fix: disable debugger code in non debug builds
1 parent 93bb4e6 commit 36e8921

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

utils/build-apple-framework.sh

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,13 @@ function build_host_hermesc {
4242

4343
# Utility function to configure an Apple framework
4444
function configure_apple_framework {
45-
local build_cli_tools
45+
local build_cli_tools enable_debugger xcode_15_flags xcode_major_version
46+
47+
if [[ $BUILD_TYPE == "Debug" ]]; then
48+
enable_debugger="true"
49+
else
50+
enable_debugger="false"
51+
fi
4652

4753
if [[ $1 == macosx ]]; then
4854
build_cli_tools="true"
@@ -62,7 +68,7 @@ function configure_apple_framework {
6268
-DHERMES_APPLE_TARGET_PLATFORM:STRING="$1" \
6369
-DCMAKE_OSX_ARCHITECTURES:STRING="$2" \
6470
-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING="$3" \
65-
-DHERMES_ENABLE_DEBUGGER:BOOLEAN=true \
71+
-DHERMES_ENABLE_DEBUGGER:BOOLEAN="$enable_debugger" \
6672
-DHERMES_ENABLE_INTL:BOOLEAN=true \
6773
-DHERMES_ENABLE_LIBFUZZER:BOOLEAN=false \
6874
-DHERMES_ENABLE_FUZZILLI:BOOLEAN=false \

0 commit comments

Comments
 (0)