Skip to content

Commit 44648ab

Browse files
authored
fix: disable debugger on release (#13)
1 parent 9d449ca commit 44648ab

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

hermes-engine.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Pod::Spec.new do |spec|
3333
spec.ios.vendored_frameworks = "destroot/Library/Frameworks/universal/hermes.xcframework"
3434
spec.osx.vendored_frameworks = "destroot/Library/Frameworks/macosx/hermes.framework"
3535

36-
spec.xcconfig = { "CLANG_CXX_LANGUAGE_STANDARD" => "c++17", "CLANG_CXX_LIBRARY" => "compiler-default", "GCC_PREPROCESSOR_DEFINITIONS" => "HERMES_ENABLE_DEBUGGER=1" }
36+
spec.xcconfig = { "CLANG_CXX_LANGUAGE_STANDARD" => "c++17", "CLANG_CXX_LIBRARY" => "compiler-default", "GCC_PREPROCESSOR_DEFINITIONS" => "HERMES_ENABLE_DEBUGGER=0" }
3737

3838
unless ENV['hermes-artifact-url']
3939
spec.prepare_command = <<-EOS

utils/build-apple-framework.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ function configure_apple_framework {
5757
-DHERMES_APPLE_TARGET_PLATFORM:STRING="$1" \
5858
-DCMAKE_OSX_ARCHITECTURES:STRING="$2" \
5959
-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING="$3" \
60-
-DHERMES_ENABLE_DEBUGGER:BOOLEAN=true \
60+
-DHERMES_ENABLE_DEBUGGER:BOOLEAN=false \
6161
-DHERMES_ENABLE_INTL:BOOLEAN=true \
6262
-DHERMES_ENABLE_LIBFUZZER:BOOLEAN=false \
6363
-DHERMES_ENABLE_FUZZILLI:BOOLEAN=false \

0 commit comments

Comments
 (0)