Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded Underscore Dependency #22

Open
DMPS opened this issue Jul 2, 2018 · 0 comments
Open

Unneeded Underscore Dependency #22

DMPS opened this issue Jul 2, 2018 · 0 comments

Comments

@DMPS
Copy link

DMPS commented Jul 2, 2018

Hi,

I am looking into using your library to test my company's Alexa Skill and I am wondering why you rely on underscore?

I have looked through your code and you only seem to use underscore for the following methods:

  1. _.extend
  2. _.each
  3. .isUndefined/.isNull/_.isString/_isEmpty

Each of these methods have easy ES5 (or earlier) solutions. As you alreasy use ES6 all over the place, there seems to be no reason to try to support older node versions.

If you like, I can raise a PR to strip out the underscore dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant