Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-03-07 #37938

Closed
43 tasks done
github-actions bot opened this issue Mar 7, 2024 · 19 comments
Closed
43 tasks done

Deploy Checklist: New Expensify 2024-03-07 #37938

github-actions bot opened this issue Mar 7, 2024 · 19 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Release Version: 1.4.49-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@roryabraham roryabraham added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 7, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Mar 8, 2024

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.49-0 🚀

@Julesssss
Copy link
Contributor

Checking off #37959 as it is a minor issue.

@rlinoz
Copy link
Contributor

rlinoz commented Mar 8, 2024

Checking off #37964 since we can't reproduce and there is no way to access the feature in product yet.

@twisterdotcom
Copy link
Contributor

Checked off #37960 as I couldn't reproduce.

@mountiny
Copy link
Contributor

mountiny commented Mar 8, 2024

Demoting #37958 as its a new feature

@kavimuru
Copy link

kavimuru commented Mar 8, 2024

Regression is 16% left.
unchecked PR
#37727 failing with #37979 repro in PROD checking it off
#37525 failing with #37959 and #37958

@luacmartins
Copy link
Contributor

Checking off #37965. Fixed in staging!

@roryabraham
Copy link
Contributor

@luacmartins
Copy link
Contributor

Checked off 37942. Tested in staging and it's a pass

@francoisl
Copy link
Contributor

Demoted #38000 to non-blocker backend fix, checking it off.

@kavimuru
Copy link

kavimuru commented Mar 8, 2024

Regression is down to 7%

unchecked PR
#37525 failing with #37959 and #37958

@kavimuru
Copy link

kavimuru commented Mar 9, 2024

@roryabraham Regression is completed.

unchecked PR
#37525 failing with #37959 and #37958

Open blockers:
#37939
#37963
#37970
#38003
#38008

@roryabraham
Copy link
Contributor

Checking off #37963 because it is reproducible in production

@roryabraham
Copy link
Contributor

roryabraham commented Mar 10, 2024

Please DO NOT ship this checklist before we fix #37963 either with a fix or with the revert. I want to CP the revert to staging before we send this out so that we can get the fix out to prod ASAP

Edit: Revert CP'd and fix verified on staging

@luacmartins luacmartins self-assigned this Mar 11, 2024
@mountiny
Copy link
Contributor

Demoted #37939 as its a new feature too and not so likely to reproduce

@mountiny
Copy link
Contributor

Demoted #37970, the error is not frontend related

@mountiny
Copy link
Contributor

Graphs looking good, github too and no new crashes

@mountiny
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

10 participants