Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-10-29 #51635

Closed
65 tasks done
github-actions bot opened this issue Oct 29, 2024 · 24 comments
Closed
65 tasks done

Deploy Checklist: New Expensify 2024-10-29 #51635

github-actions bot opened this issue Oct 29, 2024 · 24 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024

Release Version: 9.0.55-10
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 29, 2024
@Beamanator Beamanator assigned Beamanator and unassigned nkuoch Oct 29, 2024
@Beamanator
Copy link
Contributor

@mvtglobally did you already test out #51581 and #51553? Or did they look small enough no testing is necessary?

@mvtglobally
Copy link

@Beamanator both are no QA, so checked them off. We started regression and other PRs

@Beamanator
Copy link
Contributor

Aah now i see the "No QA" in the test steps, thanks for confirming & responding quick!! 🙏

@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.55-0 🚀

@mvtglobally
Copy link

@Beamanator We still do not see Hybrid app builds updated. Can you check if those are stuck in any way?

@mvtglobally
Copy link

Regression is at 55% completed

@Beamanator
Copy link
Contributor

Checking off #51654 as fixed by #51662

@mvtglobally
Copy link

Regression is at 74% completed

We are blocked with Android Hybrid app due to #51682

@jasperhuangg
Copy link
Contributor

Demoted #51696

@mvtglobally
Copy link

Regression is at 17% left
We got Android build

PRs
#50773 is failing #51649. Not an issue checking off
#51110 - Pending validation on Desktop
#51328 - is blocked as its seems a dev only #51385 (comment). Can we check it off?
#51340 - is failing with KI #51395. repro in PROD. Checking off
#51458 - is failing #49813 and pending validation on Web
#51516 - is failing #51526. repro in PROD. Checking off
#51746 (comment) - Checking off
Checking CPs.

@mvtglobally
Copy link

Regression is at 5% left

PRs
#51110 - Pending validation on Desktop
#51328 - is blocked as its seems a dev only #51385 (comment). Can we check it off?
#51458 - is failing #49813 and pending validation on Web
#51693 (comment) - Checking off
#51231 - Pending validation on all platforms
#51456 - Pending validation on all platforms

Blockers
#51584
#51653
#51664
#51682
#51728

@mvtglobally
Copy link

mvtglobally commented Oct 31, 2024

Regression is at couple steps left

PRs
#51231 - is failing with #51265 and logging new issue
#51328 - is blocked as its seems a dev only #51385 (comment). Can we check it off?
#51458 - is failing #49813 and pending validation on Web

Blockers
#51584
#51653
#51664
#51682
#51728

@Beamanator
Copy link
Contributor

Checking off #51664 as fixed by #51702 and #51684

@Beamanator
Copy link
Contributor

Checking off #51682 as fixed by #51746

@Beamanator
Copy link
Contributor

Checking off #51584 as it was reproduced on builds as old as 1 week ago

@Beamanator
Copy link
Contributor

Checking off #51653 as fixed by #51659

@Beamanator
Copy link
Contributor

Marking #51728 NAB as it's a pretty small bug & easy to work around

@Beamanator
Copy link
Contributor

Checking off #51231 as #51265 was marked NAB in the last checklist

@Beamanator
Copy link
Contributor

Beamanator commented Oct 31, 2024

#51328 - is blocked as its seems a dev only #51385 (comment). Can we check it off?

Yes that makes sense! checking off!

@Beamanator
Copy link
Contributor

#51458 - is failing #49813 and pending validation on Web

Checking off this one as well

@mvtglobally
Copy link

Regression is completed.

New blocker just logged, potentially related to PR #51231

@Beamanator
Copy link
Contributor

Internal PR QA'd well 👍 just waiting on last blocker to be fixed, then will deploy 👍

@Beamanator
Copy link
Contributor

closed #51776 as fixed by #51777

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants