-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] e2e: allow tests failure #51248
[NoQA] e2e: allow tests failure #51248
Conversation
6fc5da7
to
d2c4a0d
Compare
we split this up to two PRs #51248 |
Sorry @s77rt no c+ review required here |
eeb623d
to
0bf8152
Compare
CI works as expected - it should be ready for review 😊 |
env: | ||
GITHUB_TOKEN: ${{ github.token }} | ||
|
||
- name: 'Announce skipped tests in Slack' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: 'Announce skipped tests in Slack' | |
- name: Announce skipped tests in Slack |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
tests were passing |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.55-1 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.55-10 🚀
|
Details
Skip test and don't fail a pipeline if test can not be executed successfully.
Fixed Issues
$ #51154
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop