Upgrade to React Native 0.76 #51475

j-piasecki · 2024-10-25T14:54:13Z

Details

This PR upgrades the version of React Native used in the App to 0.76.

Fixed Issues

$ #48911
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

IuliiaHerets · 2024-11-17T18:31:55Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Android - Expense - App shows blank page after submitting expense to user

Version Number: 9.0.61-0
Reproducible in staging?: N
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

App is logged in with Expensifail account (not reproducible with Gmail).

Launch New Expensify app.
Go to FAB > Submit expense.
Enter amount > Next.
Select any user.
Tap Submit.

Expected Result:

App will show skeleton loading after submitting expense to user (staging and production behavior).

Actual Result:

App shows blank page after submitting expense to user.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Screenrecorder-2024-11-17-20-02-53-116.mp4

View all open jobs on GitHub

IuliiaHerets · 2024-11-17T18:36:48Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Android - Chat - App crashes when editing a hyperlink

Version Number: 9.0.61-0
Reproducible in staging?: N
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Open any chat
Send google.com (or any other hyperlink)
Long tap on the hyperlink text you just sent > Edit comment
Start editing the link by clearing the content

Expected Result:

The link is successfully cleared and edited

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Screenshots/Videos

1711_1.txt

Bug6667813_1731862103067.screen-20241117-193847.mp4

View all open jobs on GitHub

IuliiaHerets · 2024-11-17T18:47:16Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Android - Chat scrolls to the top after deleting track expense and returning to self DM

Version Number: 9.0.61-0
Reproducible in staging?: N
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Launch New Expensify app.
Go to self DM.
Track a few expenses until the chat is scrollable (dismiss all actionable whispers).
Track another expense
Tap on the expense.
Dismiss the keyboard.
Tap on the report header.
Tap Delete expense.
Delete the expense.

Expected Result:

The chat will not scroll to the top after deleting track expense and returning to self DM.

Actual Result:

The chat will not scroll to the top after deleting track expense and returning to self DM.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Screenrecorder-2024-11-17-20-35-41-682.mp4

View all open jobs on GitHub

j-piasecki · 2024-11-18T10:30:14Z

Here's a list of all reported issues:

Browser

Attachment - "Content-Security-Policy directive name" console error when uploading a PDF

Not reproducible after merging main branch

Screen.Recording.2024-11-18.at.11.34.16.mov

Wallet - The page redirects me to the Inbox section when I put an incorrect MC

Not reproducible after merging main branch

Screen.Recording.2024-11-18.at.11.40.06.mov

Group - Save button doesn't work when trying to upload profile picture

Not reproducible after merging main branch

Screen.Recording.2024-11-18.at.11.43.46.mov

Chat - Public image is not displayed

Not reproducible after merging main branch

Screen.Recording.2024-11-18.at.11.46.09.mov

Wallet- App stop responding when validate account

Not reproducible after merging main branch

Screen.Recording.2024-11-18.at.11.48.53.mov

Please enter the MC sent to message missing in validate your account page

Not reproducible after merging main branch

Screen.Recording.2024-11-18.at.11.51.30.mov

LHN- There is GBR instead of RBR for missed tag information in WS LHN

Not reproducible after merging main branch

Screen.Recording.2024-11-18.at.11.59.49.mov

Android

Expense - Saved description disappears when reopening Description page

Fixed by afd9788

2024-11-19-16-50-26.mp4

Expense - Cursor is in front of the text when opening Description or Merchant field

Fixed by 6ebb122

Screen.Recording.2024-11-20.at.17.13.09.mov

Chat - App crashes after selecting an emoji from suggestion list

Fixed by ac87ce6

Screen.Recording.2024-11-20.at.17.11.48.mov

Chat - Draft is not shown when reopening chat

Fixed by afd9788

2024-11-19-17-01-53.mp4

Chat - Text input is always highlighted after each loading

Fixed by 9e0c2f2

Screen.Recording.2024-11-22.at.13.20.02.mov

Workspace -Keyboard is not automatically opened when editing name of a workspace

Fixed by 7adc49a

Screen.Recording.2024-11-22.at.13.32.49.mov

Expense - App shows blank page after submitting expense to user

Not reproducible after merging main branch

Screen.Recording.2024-11-22.at.13.34.31.mov

Chat - App crashes when editing a hyperlink

Chat scrolls to the top after deleting track expense and returning to self DM

Taxes - Huge spacing between keyboard and Save button

Expense - App crashes when exchanging expenses offline and returning online

iOS

Attachment - Empty screen is displayed instead of attachment preview before sending

Fixed by fbd9354

Screen.Recording.2024-11-18.at.18.07.22.mov

Thread - Empty screen with keyboard when creating a new thread

Not reproducible after merging main branch

Screen.Recording.2024-11-19.at.11.19.42.mov

IuliiaHerets · 2024-11-18T12:02:50Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

iOS - Thread - Empty screen with keyboard when creating a new thread

Version Number: 9.0.61-0
Reproducible in staging?: N
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Launch new Expesify and login
Access a chat that you didn't create a thread before
Add a new message
Tap and hold on the message
Tap on Reply in Thread

Expected Result:

The thread screen is shown and user can add a message to the new thread

Actual Result:

An empty screen with the keyboard appears. A user can at times add a thread on the empty page in which case after a couple of minutes the thread will work but it's blocked at first

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6667976_1731882800156.RPReplay_Final1731882374.mp4

View all open jobs on GitHub

IuliiaHerets · 2024-11-18T12:12:46Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Android - Taxes - Huge spacing between keyboard and Save button

Version Number: 9.0.61-0
Reproducible in staging?: N
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Launch New Expensify app.
Go to workspace settings > Taxes.
Tap Add rate.
Tap Name.

Expected Result:

Save button will be above the keyboard without no massive space in between.

Actual Result:

Save button appears above the keyboard with massive space in between.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6668244_1731923713089.Screen_Recording_20241118_171934_Settings.mp4

View all open jobs on GitHub

IuliiaHerets · 2024-11-18T18:51:24Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Android - Expense - App crashes when exchanging expenses offline and returning online

Version Number: 9.0.61-0
Reproducible in staging?: N
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

User A and User B have never chatted before.

Go to staging.new.expensify.com
[User A (Android)] Go offline
[User A (Android)] Submit an expense to User B
[User B] While online. submit an expense of the same amount to User A
[User A (Android)] Go online while stay in main chat with User B.

Expected Result:

App will not crash when user A returns online and chat refreshes.

Actual Result:

App crashes when user A returns online and chat refreshes.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1811_1.txt

Bug6668544_1731943777161.Screen_Recording_20241118_231656_New_Expensify_AdHoc.mp4

View all open jobs on GitHub

CyberAndrii · 2024-11-20T12:03:00Z

Hey @j-piasecki, I'm pretty sure we can remove changes made in #18837 as it was a workaround to an RN bug that got fixed a long time ago. This callback don't even run because uiManager.addUIBlock doesn't work on new arch anymore.

github-actions · 2024-11-28T08:05:11Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-28T08:32:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51475/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51475/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51475/NewExpensify.dmg	https://51475.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2024-11-28T11:20:02Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-28T11:31:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

👀 View the workflow run that generated this build 👀

WoLewicki and others added 16 commits October 21, 2024 17:32

feat: update patches for expo

44682c9

feat: bump to newest RN

ffae2d9

chore: update patch numbers

e520b04

feat: update expo

d4c742b

chore: merge current main

54586a7

fix: update patches and fix gradle build

9df77bf

Bump to stable 0.76 and expo preview 3

43696bd

Add patch for mapbox

91253f2

Fix headless tasks causing crash

49d1255

Merge branch 'main' into @wolewicki/rn-76-upgrade

55aa7d3

Fix Android build

d9ed4fa

Merge branch 'main' into @wolewicki/rn-76-upgrade

9e2ef24

Fix lint

7ca13d2

Fix mock

3d5d0af

Merge branch 'main' into @wolewicki/rn-76-upgrade

99ae53e

Build Github Actions

3086b54

mountiny added the Ready To Build label Oct 28, 2024

This comment has been minimized.

Sign in to view

WoLewicki and others added 12 commits October 28, 2024 17:57

fix: enable bridgeless again

5a8cdbc

Merge branch 'main' into @wolewicki/rn-76-upgrade

e5f32d7

Override regexpu-core version

af36d31

Fix ios build

30bf3a5

Move git tests to other directory

ece3d70

Fix middleware tests

926bde4

Merge process from Expo and NodeJS

7c3f55d

Restore previous configs

7e6d265

Fix types & eslint

7dfffdd

Transpile updated expo modules on web

4358c2e

Add patches for type imports

50be77f

Merge branch 'main' into @wolewicki/rn-76-upgrade

4df9f59

Merge branch 'main' into @wolewicki/rn-76-upgrade

4151ab5

Fix mask persisting after recycling

fbd9354

j-piasecki added 6 commits November 19, 2024 09:59

Merge branch 'main' into @wolewicki/rn-76-upgrade

54c21aa

Update github actions

e05da30

Fix text input value not being set

afd9788

Merge branch 'main' into @wolewicki/rn-76-upgrade

0306598

Fix selection not applying in TextInput

6ebb122

Fix crash on emoji selection

ac87ce6

j-piasecki and others added 5 commits November 22, 2024 09:49

Fix text selection on change

9e0c2f2

Merge branch 'main' into @wolewicki/rn-76-upgrade

c847cd8

Fix workspace name screen not opening keyboard

7adc49a

feat: align with hybrid app

f237bd4

chore: run gh-actions-build

47f4a1c

hannojg mentioned this pull request Nov 27, 2024

[HOLD App#51475] iOS - App crashing when using profiling tool #53061

Open

8 tasks

j-piasecki added 2 commits November 27, 2024 11:19

Fix crash on editing message

267b866

Merge branch 'main' into @wolewicki/rn-76-upgrade

b1b1b8a

Merge branch 'main' into @wolewicki/rn-76-upgrade

f89ec5d

Fix SrollView jump on deleting an expense

e18e5ca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to React Native 0.76 #51475

Upgrade to React Native 0.76 #51475

j-piasecki commented Oct 25, 2024

This comment has been minimized.

IuliiaHerets commented Nov 17, 2024 •

edited

Loading

IuliiaHerets commented Nov 17, 2024

IuliiaHerets commented Nov 17, 2024

j-piasecki commented Nov 18, 2024 •

edited

Loading

IuliiaHerets commented Nov 18, 2024

IuliiaHerets commented Nov 18, 2024

IuliiaHerets commented Nov 18, 2024

CyberAndrii commented Nov 20, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

Upgrade to React Native 0.76 #51475

Are you sure you want to change the base?

Upgrade to React Native 0.76 #51475

Conversation

j-piasecki commented Oct 25, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

This comment has been minimized.

IuliiaHerets commented Nov 17, 2024 • edited Loading

Android - Expense - App shows blank page after submitting expense to user

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

IuliiaHerets commented Nov 17, 2024

Android - Chat - App crashes when editing a hyperlink

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

IuliiaHerets commented Nov 17, 2024

Android - Chat scrolls to the top after deleting track expense and returning to self DM

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

j-piasecki commented Nov 18, 2024 • edited Loading

Browser

Android

iOS

IuliiaHerets commented Nov 18, 2024

iOS - Thread - Empty screen with keyboard when creating a new thread

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

IuliiaHerets commented Nov 18, 2024

Android - Taxes - Huge spacing between keyboard and Save button

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

IuliiaHerets commented Nov 18, 2024

Android - Expense - App crashes when exchanging expenses offline and returning online

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

CyberAndrii commented Nov 20, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

IuliiaHerets commented Nov 17, 2024 •

edited

Loading

j-piasecki commented Nov 18, 2024 •

edited

Loading