fix: android-headless-talkback-accessibility#19
fix: android-headless-talkback-accessibility#19TaduJR wants to merge 4 commits intoExpensify:masterfrom
Conversation
|
@TaduJR Please merge main into your branch to fix the GitHub validation errors? |
| accessibilityLabel={accessibilityLabel} | ||
| accessibilityState={{ disabled }} | ||
| onAccessibilityAction={handleAccessibilityAction} | ||
| accessibilityActions={[{ name: 'activate' }]} |
There was a problem hiding this comment.
Should we add support for 'escape' action too?
There was a problem hiding this comment.
The iOS does not have this functionality, so adding for Android would make it inconsistent IMO. But if it's need we can do a separate follow-up PR.
There was a problem hiding this comment.
@TaduJR, it's the other way around, iOS does support it, Android doesn't. Let's add it here
so adding for Android would make it inconsistent IMO
But that still stands true, how do we close the picker on Android? Is it the 'collapse' action?
There was a problem hiding this comment.
For iOS, yes - we could add 'escape' action to the Modal wrapper so VoiceOver users can dismiss with two-finger scrub (will call togglePicker(true)).
For Android, 'collapse' isn't the right action because when the native Picker opens, it's a system dialog that takes focus away from our wrapper. The accessibilityActions aren't reachable while the dialog is open. The
system dialog handles its own dismissal via back button/gesture. So No additional action needed on our side.
|
@TaduJR Please can we get some movement on this. |
|
Hey @inimaga Very sorry for the delay 🙏 I was having some deploy blockers recently. Will surely handle it tomorrow. Thanks for the bump! |
…r-select-expensify into fix/android-headless-talkback-accessibility
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Oh, forgot codex is not install on this fork 😅 |
3 participants
Fixes Expensify/App#77542
Demo:
Screen_Recording_20260122_065943_New.Expensify.Dev.mp4