Change allowed_slots param type in bigip_vcmp_guest to match F5 expected type #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allowedSlots parameter in the F5 API is of type list of int. Currently the bigip_vcmp_guest module has this parameter as a list of str. When the module does a compare against the value from the F5 (list of int) and the variable supplied to the module (list of str) it always reports a diff. This results in Ansible reporting a change to the guest even when the configuration being pushed matches what is on the F5. Changing the parameter type in the module to a list of int to match what F5 expects correctly returns 'OK' when the allowed_slots variable matches what is configured on the F5.
This change was successfully tested on Ansible version 2.15.8 and F5 version 15.1.10.2 Build 0.44.2.
Closes #2394