Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML tags & CSS styles #55

Open
lucymonie opened this issue Oct 21, 2016 · 2 comments
Open

HTML tags & CSS styles #55

lucymonie opened this issue Oct 21, 2016 · 2 comments

Comments

@lucymonie
Copy link

  • I'm not clear with there's an 'xs' in the col- styles. Is there a reason for this?
  • Classes have some underscores and some hyphens but it's not clear why this is. Perhaps develop a consistent team style so you can tell at a glance what type of style this is (eg BEM).
  • Could use 'articles' tag for profiles to increase accessibility.
@tbtommyb
Copy link

Some other minor CSS comments:

  • Duplicate semicolon on line 59 (I hadn't heard of currentColor before, good usage!).
  • It would help if you used comments to create sections and headings in the CSS.
  • There's inconsistent spacing (e.g. after colons, before braces) and inconsistent naming styles (e.g. camelCase on lines 159, 225 but hyphens elsewhere).
  • Some unused rules e.g. #name1 on line 192. A fixed_height class is applied to some HTML tags but not defined.

@tbtommyb
Copy link

Also you have multiple types of container class - is it possible to simplify that a bit (I'm not sure)?

This was referenced Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants