Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNEB surface facet index mismatch #988

Open
jungsdao opened this issue Jan 31, 2025 · 3 comments
Open

OCPNEB surface facet index mismatch #988

jungsdao opened this issue Jan 31, 2025 · 3 comments
Assignees

Comments

@jungsdao
Copy link

What would you like to report?

Hello, thank you for relaseaing OCPNEB database.
While I was looking at some of trajectory, I realized that facet indices in filenames are not matching with the slab when I generate from OCP interface.
One example can be following.

bulk = Bulk(bulk_id_from_db=9217, bulk_db_path=BULK_PKL_PATH)
slabs = Slab.from_bulk_get_specific_millers(bulk = bulk, specific_millers=(2,1,1))

which gives

Image

But when I open transfer_id_331_9217_6_211-2_neb1.0.traj
Slab looks like

Image
And this actually matches with

bulk = Bulk(bulk_id_from_db=9217, bulk_db_path=BULK_PKL_PATH)
slabs = Slab.from_bulk_get_specific_millers(bulk = bulk, specific_millers=(2,1,0))

I think it could be confusing to follow current filenames to construct the same slab as in the database.

@mshuaibii
Copy link
Collaborator

Just to be sure - did you index the corresponding shift? transfer_id_331_9217_6_211-2_neb1.0.traj should be:

bulk = Bulk(bulk_id_from_db=9217, bulk_db_path=BULK_PKL_PATH)
slabs = Slab.from_bulk_get_specific_millers(bulk = bulk, specific_millers=(2,1,1))
slab = slabs[2]

@jungsdao
Copy link
Author

Hi thanks for the answer.
I think It's not the problem of shift.
The slabs I get from following have completely different cell dimensions.
slabs = Slab.from_bulk_get_specific_millers(bulk = bulk, specific_millers=(2,1,1))
You can try on this specific example.

@mshuaibii
Copy link
Collaborator

Hmm I do see what you mean, I was able to reproduce this on my end. The way the naming was done was straightforward so I do think it could be a version issue with the underlying generation code. We'll look into it and see if we can find what combination reproduces the old data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants