Skip to content

Commit 93fe2ce

Browse files
committed
refactor: review 피드백 반영
1 parent b9ea477 commit 93fe2ce

File tree

4 files changed

+13
-20
lines changed

4 files changed

+13
-20
lines changed

src/app/components/modal/modals/alert/ApplicationDetailModal.tsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,6 @@ const ApplicationDetailModal = ({
5858
className
5959
)}
6060
>
61-
<button
62-
onClick={onClose}
63-
className="absolute right-4 top-4 flex h-8 w-8 items-center justify-center rounded-full bg-white text-gray-400 hover:text-gray-600"
64-
>
65-
<Image src="/icons/x/x-sm.svg" alt="close" width={16} height={16} className="block sm:hidden" />
66-
<Image src="/icons/x/x-md.svg" alt="close" width={20} height={20} className="hidden sm:block" />
67-
</button>
68-
6961
<div className="flex h-full flex-col">
7062
<div className="mb-6 md:mb-8">
7163
<div className="text-lg font-semibold md:text-2xl">내 지원 내역</div>
@@ -114,6 +106,15 @@ const ApplicationDetailModal = ({
114106
</Button>
115107
</Link>
116108
</div>
109+
110+
<button
111+
onClick={onClose}
112+
aria-label="모달 닫기"
113+
className="absolute right-4 top-4 flex h-8 w-8 items-center justify-center rounded-full bg-white text-gray-400 hover:text-gray-600"
114+
>
115+
<Image src="/icons/x/x-sm.svg" alt="" width={16} height={16} className="block sm:hidden" />
116+
<Image src="/icons/x/x-md.svg" alt="" width={20} height={20} className="hidden sm:block" />
117+
</button>
117118
</div>
118119
</div>
119120
</div>

src/app/components/modal/modals/alert/FormContinueModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const FormContinueModal = ({ isOpen, onClose, className }: FormContinueModalProp
2525
<Image src="/icons/x/x-sm.svg" alt="close" width={16} height={16} className="block sm:hidden" />
2626
<Image src="/icons/x/x-md.svg" alt="close" width={20} height={20} className="hidden sm:block" />
2727
</button>
28-
<div className="flex h-full flex-col items-center pt-8 text-center md:pt-12">
28+
<div className="flex h-full flex-col items-center py-4 text-center md:py-6">
2929
<div className="flex items-center justify-center">
3030
<div className="relative h-20 w-20 md:h-[120px] md:w-[120px]">
3131
<Image

src/app/components/modal/modals/alert/RecruitmentClosedModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const RecruitmentClosedModal = ({ formId, isOpen, onClose, className }: Recruitm
2626
<Image src="/icons/x/x-sm.svg" alt="close" width={16} height={16} className="block sm:hidden" />
2727
<Image src="/icons/x/x-md.svg" alt="close" width={20} height={20} className="hidden sm:block" />
2828
</button>
29-
<div className="flex h-full flex-col items-center pt-8 text-center md:pt-12">
29+
<div className="flex h-full flex-col items-center py-4 text-center md:py-6">
3030
<div className="flex items-center justify-center">
3131
<div className="relative h-20 w-20 md:h-[120px] md:w-[120px]">
3232
<Image

src/types/textInput.d.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,24 +9,16 @@ export interface BaseTextAreaProps extends React.TextareaHTMLAttributes<HTMLText
99
export interface BaseInputProps extends React.InputHTMLAttributes<HTMLInputElement> {
1010
variant: "white" | "transparent";
1111
size?: string;
12-
placeholder?: string;
13-
disabled?: boolean;
14-
value?: string;
15-
readOnly?: boolean;
1612
errorMessage?: string;
1713
feedbackMessage?: string;
1814
beforeIcon?: React.ReactNode;
1915
afterIcon?: React.ReactNode;
2016
afterString?: string;
21-
wrapperClassName?: string; // 부가적인 tailwind css 클래스
22-
innerClassName?: string; // 부가적인 tailwind css 클래스
17+
wrapperClassName?: string;
18+
innerClassName?: string;
2319
anotherHoverStyle?: string;
2420
}
2521

26-
export type TextAreaProps = Omit<BaseTextAreaProps, "variant">;
27-
28-
export type TextInputProps = Omit<BaseInputProps, "variant">;
29-
3022
export interface BaseFileInputProps {
3123
name: string;
3224
variant: "upload" | "download";

0 commit comments

Comments
 (0)