Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long-lasting rift refreshes can fail, locking players out of the rift #7179

Open
hRobert12 opened this issue Mar 4, 2025 · 1 comment
Open

Comments

@hRobert12
Copy link

Modpack

FTB OceanBlock 2

Modpack version

1.3.3

Launcher

Other...

Has the pack been modified

No

Log Files

debug.log

Describe the bug

As seen in the logs, it appears that when the rift refreshes for a team, if the refresh takes too long, it starts to spew out file related errors and the refresh fails. This ultimately causes the affected team to be unable to use the rift after exiting.

Steps to reproduce

  1. Install the pack on a slow hard drive
  2. Enter a world and enter the rift
  3. Exit the rift
  4. Notice that the hard drive is constantly clicking and the rift refreshes fail, causing the rift to be "unstable"

You can exaggerate the issue by running /tick sprint 1d after exiting the rift.

Expected behaviour

The refresh to work correctly and the rift to allow me to enter again

Screenshots

No response

Additional information

I installed the pack using the FTB app and imported it into MultiMC. I launched the pack using MultiMC.

I suspect this is caused by the rift helper mod not checking if a refresh is already happening before kicking another one off (since the refreshes start every minute according to the config).

Note that the failed refreshes can only be observed in the game's logs. In-game the player is only told that the rift is still "unstable."

@Gaz492
Copy link
Member

Gaz492 commented Mar 4, 2025

Thanks for reporting this, our developer will have a look over the mod and see if they are able to reproduce.

On a side note, if your hard drive is clicking you may want to check the health (S.M.A.R.T) data for it as clicking can be a sign that your drive is starting to fail.

@github-actions github-actions bot added the state: Awaiting Reply A reply is awaited from a user. label Mar 4, 2025
@Gaz492 Gaz492 removed the state: Awaiting Reply A reply is awaited from a user. label Mar 4, 2025
desht added a commit to FTBTeam/FTB-Rift-Helper that referenced this issue Mar 4, 2025
If chunk scanning takes too long, it was possible for a new refresh
to start while another is still in progress, causing excessive disk/cpu
activity and a bunch of warnings in the server log.

Add an in-progress per-team "lock" to prevent this and also increase
the default refresh check interval from 1 minute to 5 minutes.

FTBTeam/FTB-Modpack-Issues#7179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants