Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant functions #3

Open
kamocat opened this issue Oct 24, 2019 · 0 comments
Open

Redundant functions #3

kamocat opened this issue Oct 24, 2019 · 0 comments

Comments

@kamocat
Copy link

kamocat commented Oct 24, 2019

In your RTC_DS3231 class, ArmAlarm and AlarmInterrupt appear to do the same function. That is, the manipulate the same bits in the control register, since A1IE = 0.

I recommend removing the alarmInterrupt function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kamocat