Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Hashes #29

Open
hypherionmc opened this issue Jan 22, 2024 · 0 comments
Open

File Hashes #29

hypherionmc opened this issue Jan 22, 2024 · 0 comments

Comments

@hypherionmc
Copy link

hypherionmc commented Jan 22, 2024

Hey there

I'm working on a little tool for modders and modpack makers.

The tool is basically a launcher, but for servers (for local testing and debugging without a dev env). To speed up instance creation and to save bandwidth, the launcher caches downloads.

To ensure a download is not corrupt, it checks the file against a hash (SHA1, SHA256 etc). Currently, your meta API doesn't include file hashes. While it's possible for me to get these from the maven, some cases like the server jar generated by the jar endpoint, won't work, since the file is modified before being served by the API.

I guess I can just make a request to get the SHA, but to build an initial hash base would require a LOT of requests, which I don't think any of us want lol.

This feature could also be useful for other launcher and tool devs, that use a similar caching system

I am even willing to make a pull request for this, if it's something you'd be interested in adding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant