Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assignAction.LengthExpression in marshalFrom missing pointer. #48

Open
Y-Less opened this issue Jun 19, 2019 · 5 comments
Open

assignAction.LengthExpression in marshalFrom missing pointer. #48

Y-Less opened this issue Jun 19, 2019 · 5 comments

Comments

@Y-Less
Copy link
Contributor

Y-Less commented Jun 19, 2019

It generates:

var fieldPointer = new SharpVk.Multivendor.DebugUtilsLabel[(uint)(QueueLabelCount)];

Instead of:

var fieldPointer = new SharpVk.Multivendor.DebugUtilsLabel[(uint)(pointer->QueueLabelCount)];
@FacticiusVir
Copy link
Owner

Where is this line generated? Is this for the newer patches?

@Y-Less
Copy link
Contributor Author

Y-Less commented Jun 19, 2019

It isn't currently generated anywhere, but that's the result of disabling the EndsWidth("Info") checks on marshaling generation. I don't know if that should be considered a bug or not, since it isn't encountered in normal code, but isn't (or shouldn't be) a result of that change.

@FacticiusVir
Copy link
Owner

Okay, I think I understand a little better having looked through the "...Info" issue - I'll come back to this once I've resolved that.

@Y-Less
Copy link
Contributor Author

Y-Less commented Jun 20, 2019

From my reading of the spec, even as of 1.1.111 the DebugUtils callback is still the only one where an object is passed back, rather than just PODs. Thus you could really solve two or three issues at once by putting the demarshalling code for those objects (which I already wrote and posted in #49) in the .partial file, since those are hand-coded. I know that's not the "correct" solution, but does solve several at once until a time when the spec necessitates solving it further (and who knows when/if that will be).

I could make a pull request if you like.

@FacticiusVir
Copy link
Owner

Thanks for the offer! I'm going to have a dig and see if I can tidy up some of the generator logic to start with, as I need to catch up with the current patch in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants