Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RegisterProgress+RegisterRequestProgress #994

Open
rpl-ffl opened this issue Feb 12, 2024 · 0 comments
Open

Refactor RegisterProgress+RegisterRequestProgress #994

rpl-ffl opened this issue Feb 12, 2024 · 0 comments

Comments

@rpl-ffl
Copy link
Collaborator

rpl-ffl commented Feb 12, 2024

This item is developed and tested in branch /rapol/experimental/amneris.

However, this relies on the backend to work. This branch should be merged after the backend is tested and reviewed.

  1. RegisterRun -> Create multiple small extensions rather than singular big extensions:

    1. [RegisterRunMetadata] Extension to record metadata and record error if it happens
    2. [RegisterBlockTracker / RegisterRequestTracker] Tracker (an extension to wrap BlockProgressTracker/RequestProgressTracker or simply use as-is) dynamically whether it is aida-vm-sdb or aida-rpc.
      a. Currently Tracker is close, e.g. private so register cannot access it -> to be open up
      b. Tracker currently hard-coded tracker.log.Noticef as output -> to extend this to arbitrary f() (not necessary printer) so that we can inject "insert into db" functionality.
  2. RegisterRun list of extensions -> to be added properly to each application because order matters

    • RegisterPostRun has to be the first into the list to capture any error -> make sure it doesn't have any functionality
    • Any functionality to create stateDb must be after the creation of StateDb.
@rpl-ffl rpl-ffl self-assigned this Feb 12, 2024
@wsodsong wsodsong reopened this Mar 19, 2024
@rpl-ffl rpl-ffl self-assigned this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants