Merge pull request #54 from uprendis/feature/forbid-rewards-claiming-with-sftm

quan8 · web-flow · commit 424031c81a77 · 2022-12-28T01:09:19.000+11:00
Forbid rewards claiming with outstanding sFTM
diff --git a/contracts/sfc/SFCLib.sol b/contracts/sfc/SFCLib.sol
@@ -365,6 +365,7 @@ contract SFCLib is SFCBase {
     }
 
     function _claimRewards(address delegator, uint256 toValidatorID) internal returns (Rewards memory rewards) {
+        require(_checkAllowedToWithdraw(delegator, toValidatorID), "outstanding sFTM balance");
         _stashRewards(delegator, toValidatorID);
         rewards = _rewardsStash[delegator][toValidatorID];
         uint256 totalReward = rewards.unlockedReward.add(rewards.lockupBaseReward).add(rewards.lockupExtraReward);

Original file line number	Diff line number	Diff line change
`@@ -365,6 +365,7 @@ contract SFCLib is SFCBase {`
`365`	`365`	`}`
`366`	`366`
`367`	`367`	`function _claimRewards(address delegator, uint256 toValidatorID) internal returns (Rewards memory rewards) {`
	`368`	`+ require(_checkAllowedToWithdraw(delegator, toValidatorID), "outstanding sFTM balance");`
`368`	`369`	`_stashRewards(delegator, toValidatorID);`
`369`	`370`	`rewards = _rewardsStash[delegator][toValidatorID];`
`370`	`371`	`uint256 totalReward = rewards.unlockedReward.add(rewards.lockupBaseReward).add(rewards.lockupExtraReward);`