[SM64] Concept: Use desgraph updates to set current versions at runtime #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always running upgrade code on new objects/bones/scenes on file load, we make sure they get the new version as soon as possible. This is ideal considering we are gathering properties from keys that could be very likely exist in another addon. That said, I feel like there has to be a better approach to this? I can´t really figure out one. This does work it just feels hacky I guess, even if this is how materials work.
Lilaa3
added
sm64
Collaborator
|
this should probably work for OoT but is it still upgrading blends like before? I don't really follow what's going on |
Collaborator
Author
Yes, its just that new scenes/objects/bones are immediately set to the current version so those don´t have upgrade code run on them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always running upgrade code on new objects/bones/scenes on file load, we make sure they get the new version as soon as possible. This is ideal considering we are gathering properties from keys that could be very likely exist in another addon.
That said, I feel like there has to be a better approach to this? I can´t really figure out one. This does work it just feels hacky I guess, even if this is how materials work.
Related to Property versioning system is broken #179
@Yanis002 Would this work for oot too? Is it even worth it considering oot at least uses oot as a prefix in old names aha.