Fix #4690, duplicated property to single-property Record (#5444)

Author: JacksonJang

release-notes/VERSION

@@ -13,10 +13,17 @@ Versions: 3.x (for earlier see VERSION-2.x)
  (contributed by @sri-adarsh-kumar)
 #1980: Add method `remove(JsonPointer)` in `ContainerNode`
  (fix by @cowtowncoder, w/ Claude code)
+#3964: Deserialization issue: MismatchedInputException, Bean not
+  yet resolved
+ (reported by @detomarco)
 #4629: `@JsonIncludeProperties` and `@JsonIgnoreProperties` ignored when
   deserializing Records
  (reported by Sim Y-T)
  (fix contributed by @JacksonJang)
+#4690: InvalidDefinitionException "No fallback setter/field defined for
+  creator property" when deserializing JSON with dup property to single-property Record
+ (reported by @sseelmann)
+ (fix contributed by @JacksonJang)
 #5350: Add `DeserializationFeature.USE_NULL_FOR_MISSING_REFERENCE_VALUES` for
   selecting `null` vs "empty/absent" value when deserializing missing `Optional` value
 #5361: Fix Maven SBOM publishing (worked in 3.0.0-rc4 but not in rc5 or later)

src/main/java/tools/jackson/databind/deser/bean/BeanDeserializer.java

@@ -586,7 +586,6 @@ protected Object _deserializeUsingPropertyBased(final JsonParser p, final Deseri
 
             // Creator property?
             if (creatorProp != null) {
-                Object value;
                 if ((activeView != null) && !creatorProp.visibleInView(activeView)) {
                     p.skipChildren();
                     continue;
@@ -597,34 +596,11 @@ protected Object _deserializeUsingPropertyBased(final JsonParser p, final Deseri
                     p.skipChildren();
                     continue;
                 }
-                value = _deserializeWithErrorWrapping(p, ctxt, creatorProp);
+                Object value = _deserializeWithErrorWrapping(p, ctxt, creatorProp);
                 // Last creator property to set?
-                if (buffer.assignParameter(creatorProp, value)) {
-                    p.nextToken(); // to move to following PROPERTY_NAME/END_OBJECT
-                    Object bean;
-                    try {
-                        bean = creator.build(ctxt, buffer);
-                    } catch (Exception e) {
-                        bean = wrapInstantiationProblem(ctxt, e);
-                    }
-                    // [databind#631]: Assign current value, to be accessible by custom serializers
-                    p.assignCurrentValue(bean);
-                    // [databind#4938] Since 2.19, allow returning `null` from creator,
-                    //  but if so, need to skip all possibly relevant content
-                    if (bean == null) {
-                        _handleNullFromPropsBasedCreator(p, ctxt, unknown, referrings);
-                        return null;
-                    }
-
-                    if (bean.getClass() != _beanType.getRawClass()) {
-                        return handlePolymorphic(p, ctxt, bean, unknown);
-                    }
-                    if (unknown != null) { // nope, just extra unknown stuff...
-                        bean = handleUnknownProperties(ctxt, bean, unknown);
-                    }
-                    // or just clean?
-                    return deserialize(p, ctxt, bean);
-                }
+                // [databind#4690] cannot quit early as optimization any more
+                // if (buffer.assignParameter(creatorProp, value)) { ... build ... }
+                buffer.assignParameter(creatorProp, value);
                 continue;
             }
             // regular property? needs buffering

src/test/java/tools/jackson/databind/deser/filter/IgnoreUnknownPropertyUsingPropertyBasedTest.java

@@ -64,7 +64,8 @@ static class UnwrappedChild {
 
   @Test
   public void testAnySetterWithFailOnUnknownDisabled() throws Exception {
-    IgnoreUnknownAnySetter value = MAPPER.readValue("{\"a\":1, \"b\":2, \"x\":3, \"y\": 4}", IgnoreUnknownAnySetter.class);
+    IgnoreUnknownAnySetter value = MAPPER.readValue(
+            "{\"a\":1, \"b\":2, \"x\":3, \"y\": 4}", IgnoreUnknownAnySetter.class);
     assertNotNull(value);
     assertEquals(1, value.a);
     assertEquals(2, value.b);
@@ -75,12 +76,12 @@ public void testAnySetterWithFailOnUnknownDisabled() throws Exception {
 
   @Test
   public void testUnwrappedWithFailOnUnknownDisabled() throws Exception {
-    IgnoreUnknownUnwrapped value = MAPPER.readValue("{\"a\":1, \"b\": 2, \"x\":3, \"y\":4}", IgnoreUnknownUnwrapped.class);
+    IgnoreUnknownUnwrapped value = MAPPER.readValue(
+            "{\"a\":1, \"b\": 2, \"x\":3, \"y\":4}", IgnoreUnknownUnwrapped.class);
     assertNotNull(value);
     assertEquals(1, value.a);
     assertEquals(2, value.b);
     assertEquals(3, value.child.x);
     assertEquals(4, value.child.y);
   }
-
 }

src/test/java/tools/jackson/databind/tofix/JsonIdentityInfoAndBackReferences3964Test.java renamed to src/test/java/tools/jackson/databind/objectid/JsonIdentityInfoAndBackReferences3964Test.java

@@ -1,4 +1,4 @@
-package tools.jackson.databind.tofix;
+package tools.jackson.databind.objectid;
 
 import java.util.List;
 
@@ -8,15 +8,13 @@
 
 import tools.jackson.databind.DeserializationFeature;
 import tools.jackson.databind.ObjectMapper;
-import tools.jackson.databind.exc.MismatchedInputException;
 import tools.jackson.databind.testutil.DatabindTestUtil;
-import tools.jackson.databind.testutil.failure.JacksonTestFailureExpected;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.fail;
 
 // [databind#3964] MismatchedInputException, Bean not yet resolved
-class JsonIdentityInfoAndBackReferences3964Test extends DatabindTestUtil {
+class JsonIdentityInfoAndBackReferences3964Test extends DatabindTestUtil
+{
     /**
      * Fails : Original test
      */
@@ -206,9 +204,8 @@ public static class Shrimp {
             .enable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES).build();
 
     /**
-     * Fails : Original test
+     * Original test: used to fail
      */
-    @JacksonTestFailureExpected
     @Test
     void original() throws Exception {
         String json = "{" +
@@ -227,21 +224,14 @@ void original() throws Exception {
                 "              ]\n" +
                 "            }";
 
-        try {
-            Tree tree = MAPPER.readValue(json, Tree.class);
-            // should reach here and pass... but throws Exception and fails
-            assertEquals(tree, tree.fruits.get(0).tree);
-        } catch (MismatchedInputException e) {
-            verifyException(e, "Cannot resolve ObjectId forward reference using property 'animal'");
-            verifyException(e, "Bean not yet resolved");
-            fail("Should not reach");
-        }
+        Tree tree = MAPPER.readValue(json, Tree.class);
+        // should reach here and pass... but throws Exception and fails
+        assertEquals(tree, tree.fruits.get(0).tree);
     }
 
     /**
-     * Fails : Lean version that fails and Without getters and setters
+     * Lean version that used to fail, and Without getters and setters
      */
-    @JacksonTestFailureExpected
     @Test
     void leanWithoutGetterAndSetters() throws Exception {
         String json = a2q("{" +
@@ -260,15 +250,9 @@ void leanWithoutGetterAndSetters() throws Exception {
                 "              ]" +
                 "            }");
 
-        try {
-            Animal animal = MAPPER.readValue(json, Animal.class);
-            // should reach here and pass... but throws Exception and fails
-            assertEquals(animal, animal.cats.get(0).animal);
-        } catch (MismatchedInputException e) {
-            verifyException(e, "Cannot resolve ObjectId forward reference using property 'animal'");
-            verifyException(e, "Bean not yet resolved");
-            fail("Should not reach");
-        }
+        Animal animal = MAPPER.readValue(json, Animal.class);
+        // should reach here and pass... but throws Exception and fails
+        assertEquals(animal, animal.cats.get(0).animal);
     }
 
     /**

src/test/java/tools/jackson/databind/records/DuplicatePropertyDeserializationRecord4690Test.java

@@ -0,0 +1,62 @@
+package tools.jackson.databind.records;
+
+import org.junit.jupiter.api.Test;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+
+import tools.jackson.databind.ObjectMapper;
+import tools.jackson.databind.testutil.DatabindTestUtil;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+// [databind#4690] InvalidDefinitionException "No fallback setter/field defined for creator property"
+// when deserializing JSON with duplicated property to single-property Record
+public class DuplicatePropertyDeserializationRecord4690Test
+        extends DatabindTestUtil
+{
+    record MyRecord(String first) { }
+
+    static class MyPojo {
+        private String first;
+
+        @JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
+        MyPojo(String first) { this.first = first; }
+
+        public void setFirst(String first) {
+            this.first = first;
+        }
+
+        public String getFirst() {
+            return first;
+        }
+    }
+
+    private final ObjectMapper mapper = newJsonMapper();
+
+    @Test
+    void testDuplicatePropertyDeserialization() throws Exception {
+        final String json = a2q("{'first':'value','first':'value2'}");
+
+        MyRecord result = mapper.readValue(json, MyRecord.class);
+
+        assertNotNull(result);
+        assertEquals("value2", result.first());
+    }
+
+    @Test
+    void testDuplicatePropertyDeserialization2() throws Exception {
+        final String json = a2q("{'first':'value','second':'test1','first':'value2'}");
+
+        MyRecord result = mapper.readValue(json, MyRecord.class);
+        assertEquals("value2", result.first());
+    }
+
+    @Test
+    void testDuplicatePropertyClassDeserialization() throws Exception {
+        final String json = a2q("{'first':'value','second':'test1','first':'value2'}");
+
+        MyPojo result = mapper.readValue(json, MyPojo.class);
+        assertEquals("value2", result.getFirst());
+    }
+}