Seems like java.nio.file.Path is safe for Android API level 26#3708
Merged
cowtowncoder merged 2 commits intoFasterXML:2.15from Dec 25, 2022
Merged
Seems like java.nio.file.Path is safe for Android API level 26#3708cowtowncoder merged 2 commits intoFasterXML:2.15from
java.nio.file.Path is safe for Android API level 26#3708cowtowncoder merged 2 commits intoFasterXML:2.15from
Conversation
Member
pjfanning
commented
Dec 25, 2022
pjfanning
commented
- Jackson 2.14 now requires Java 8 and Android API level 26 or above
- this changes saves some reflection lookups but doesn't change the jackson API
cowtowncoder
approved these changes
Dec 25, 2022
cowtowncoder
changed the title
java.nio.file.Path is safe for Android API level 26
cowtowncoder
added a commit
that referenced
this pull request
Dec 25, 2022
Member
Author
|
@cowtowncoder I looked at https://developer.android.com/reference/java/nio/file/Path and this class was added in API level 26. There is no sign of java.beans.Transient being added yet. So that support class will need to stick with Reflection. |
Member
|
@pjfanning I vaguely recall this being the case... these are sort of weird types and not included in base jdk modules for Java 9 and later on but requiring Something to consider wrt 3.0 is, I think, whether to actually just drop support. But for 2.x let's leave reflection in, cannot drop without breaking expected backwards compatibility. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.