-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Kotlin 1.4 support from Kotlin module 2.15 #632
Comments
Memo: |
If Kotlin 1.4 support is dropped, it's better to set a language level or build against Kotlin std lib in a way that makes jackson-module-kotlin not binary compatible with Kotlin 1.4 at all. |
@Spikhalskiy That sounds like a good idea. So the recently closed PR that was to build using 1.7 was close but could be modified to do this. |
Although changes to README, CI are in, I hope we can consider additional changes to build, runtime checks for kotlin-core in use (to prevent users from accidentally attempting to use with pre-1.5 Kotlin). |
This is a discussion about dropping support for Kotlin 1.4 in the Jackson module. It seems that there is agreement that dropping support would make sense, and the work needed to do this is outlined. Some contributors have also suggested ways to ensure that the module is not binary compatible with Kotlin 1.4 at all, which would be better than unpredictable misbehaving at runtime. The idea of building against Kotlin 1.6 and testing against 1.5 is suggested to achieve this goal. |
Completed via #646: Jackson 2.15 version of this module will require Kotlin core of 1.5 or higher. |
As of Jackson 2.14, Kotlin module works (and is tested to work via CI) with
kotlin-core
versions 1.4 through 1.7 (1.8 is an open question). Default dependency is to kotlin-core 1.5.But it seems that there is diminishing value in trying to keep compatibility with kotlin-core 1.4 and it has been suggested it would make sense to drop support. This issue is proposing doing that with Jackson-module-kotlin 2.15.0 release.
If we decide to proceed with this, work needed includes:
1.4
from matrix build in.github/workflows/main.yml
The text was updated successfully, but these errors were encountered: