Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think it's broken due to slack UI upgrade #24

Closed
coderbec opened this issue Sep 29, 2020 · 6 comments
Closed

I think it's broken due to slack UI upgrade #24

coderbec opened this issue Sep 29, 2020 · 6 comments

Comments

@coderbec
Copy link

Not working in chrome for me anymore..

@notjoelshapiro
Copy link

+1, I'm not able to get this to work in Chrome or Firefox. Hugely disappointing.

@coderbec
Copy link
Author

coderbec commented Mar 2, 2021

Hey just checking in here because I actually did manage to get this working and I'm pretty sure the bug isn't the new UI. It's because I was trying it on a brand new slack channel -one you have manually uploaded more than one emoji yourself it appears to work fine.

@Fauntleroy
Copy link
Owner

@coderbec Thanks for raising this issue! I'm a bit confused though—the Slack admin interface hasn't changed for me:

image

Does the Slack admin look different to you? Is this happening at "orgname.slack.com/customize/emoji"?

@Fauntleroy
Copy link
Owner

On further investigation it looks like this is the root cause of the issue? #7

@ryanmaynard
Copy link

Hi all. I deleted my comment, but should have left and merely edited.
I found that "It's because I was trying it on a brand new slack channel -one you have manually uploaded more than one emoji yourself it appears to work fine." was true before this comment was posted, so I deleted my original comment, assuming it was my own ignorance, and not a bug.

@coderbec
Copy link
Author

coderbec commented Mar 4, 2021

yes, just to confirm 100% what I mean, I had one slack channel I hadn't customised yet so I got screen shots. On a new channel with no emojis yet the element you look for to insert your div isn't there yet, so it doesn't work:

Screen Shot 2021-03-04 at 12 03 44 pm

After I uploaded one parrot emoji manually the extension worked again:
Screen Shot 2021-03-04 at 12 04 58 pm

Probably too hard to fix this conditionally, so you could just put a warning on the extension page about it and save yourself the 1 star reviews?

Anyway, thanks for doing this extension and enabling our party parrot shenanigans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants