Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows affected by Stage Manager on macOS Sonoma continue rendering borders #29

Open
bobbyl140 opened this issue Dec 6, 2023 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed needs investigation Further investigations need to be performed

Comments

@bobbyl140
Copy link

I am on macOS Sonoma and using Stage Manager on macOS Sonoma, and I just installed JankyBorders earlier today. I have noticed that when a window is "minimized" (in the column on the left), the border is still in the space where the active window is. I will comment a screenshot once I'm back on my MacBook.

@FelixKratz FelixKratz added bug Something isn't working needs investigation Further investigations need to be performed labels Dec 6, 2023
@FelixKratz
Copy link
Owner

I have not used StageManager yet, but I think this is due to the window being transformed by StageManager, rather than properly marked as hidden.

This will require some digging on how to detect when a window is in StageManager reliably, in order to properly hide the border.

@bobbyl140
Copy link
Author

That makes sense. In the early days of Stage Manager, screen recording and screen sharing apps showed these windows as pixelated and "bent" if you will, like the user sees, instead of showing them like normal. This has been fixed in many apps by now though, which says it is somehow possible.

@FelixKratz
Copy link
Owner

Until this is fixed you can set the inactive color to be fully transparent, such that no window in StageManager renders a border:

borders inactive_color=0x00000000

@bobbyl140
Copy link
Author

+1 I didn't think of that, that you for pointing it out.

@FelixKratz FelixKratz pinned this issue Dec 11, 2023
@FelixKratz
Copy link
Owner

This issue is an issue with how transformed windows are handled and reported to us by macOS. If a window is transformed by the window server, we are not notified and I think there is no way of being notified about that, such that we can not react to a window transformation properly. The only solution to this would be to poll the windows transform. But I don't want to do that for performance reasons.

Any further ideas are welcome.

@FelixKratz FelixKratz added the help wanted Extra attention is needed label Dec 20, 2023
@FelixKratz FelixKratz unpinned this issue Dec 28, 2023
@ethanuppal
Copy link

borders inactive_color=0x00000000

This is great! It might be good idea to add this to the README.

@Bellavene
Copy link

Bellavene commented Jun 10, 2024

This issue is an issue with how transformed windows are handled and reported to us by macOS. If a window is transformed by the window server, we are not notified and I think there is no way of being notified about that, such that we can not react to a window transformation properly. The only solution to this would be to poll the windows transform. But I don't want to do that for performance reasons.

Any further ideas are welcome.

I don't think that this is a problem at all, stage manager in current implementation is not great anyway (no shortcuts, not scriptable, wasted screen space, one window logic). Most people, who use it, don't need any borders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed needs investigation Further investigations need to be performed
Projects
None yet
Development

No branches or pull requests

4 participants