Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graceful tests termination #20

Open
AlekSi opened this issue Jan 4, 2022 · 0 comments
Open

Support graceful tests termination #20

AlekSi opened this issue Jan 4, 2022 · 0 comments
Labels
code/feature Some dance tool feature is not implemented yet not ready Issues that are not ready to be worked on; PRs that should skip CI

Comments

@AlekSi
Copy link
Member

AlekSi commented Jan 4, 2022

  1. Run function should send SIGINT to go test process for graceful shutdown (once it is implemented: testing: run Cleanup if SIGINT occurs golang/go#41891). It should not just use os/exec.CommandContext as it is not graceful.
  2. After the context is canceled, it should cmd.Process.Kill() go test process after a fixed timeout of 10 seconds if it is not terminated yet.
@AlekSi AlekSi added the good first issue Good issues for new external contributors label Jan 4, 2022
@AlekSi AlekSi removed the good first issue Good issues for new external contributors label Jan 19, 2022
@AlekSi AlekSi self-assigned this Jan 19, 2022
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 20, 2022
@AlekSi AlekSi removed their assignment Jun 30, 2022
@AlekSi AlekSi added the code/feature Some dance tool feature is not implemented yet label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some dance tool feature is not implemented yet not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
None yet
Development

No branches or pull requests

1 participant