Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babashka --config parameter ignored when using hl tasks #93

Open
brianium opened this issue Mar 22, 2023 · 1 comment · May be fixed by #94
Open

Babashka --config parameter ignored when using hl tasks #93

brianium opened this issue Mar 22, 2023 · 1 comment · May be fixed by #94
Assignees
@FieryCod
Labels
bug Something isn't working

Comments

@brianium
Copy link

Describe the bug
holy-lambda.tasks does not honor the --config switch for babashka

It looks like holy-lambda.tasks slurps the contents of bb.edn regardless of the --config parameter used by babashka

To reproduce

  • Create a bb.arm.edn with a different docker image
  • Run bb --config bb.arm.edn hl:compile
  • Observe that whatever docker image is downloaded is the one stored in bb.edn

Expected behavior
The docker settings provided in bb.arm.edn should be honored. In this case I would expect the aarch64 image to be used
instead of the amd64 one used in bb.edn

Extra information:

  • OS: macOS Ventura 13.2.1
  • holy-lambda version: 0.6.6
@brianium brianium added the bug Something isn't working label Mar 22, 2023
@brianium brianium linked a pull request Mar 22, 2023 that will close this issue
Open
@brianium
Copy link
Author

I've tested the linked PR locally and it seems to work a treat.

Please let me know if I can provide anything else 🙇🏻

Thank you so much for this excellent tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FieryCod FieryCod

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use babashka.config system property in tasks brianium/holy-lambda
2 participants
@brianium @FieryCod