Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSX template testing #836

Open
akomiqaia opened this issue Oct 11, 2022 · 1 comment
Open

TSX template testing #836

akomiqaia opened this issue Oct 11, 2022 · 1 comment
Labels
components Relates to an Origami component next planning Used to mark an issue to discuss in Origami's next planning session

Comments

@akomiqaia
Copy link
Contributor

Storybook already has few suggestions around what sort of testing we could do for our TSX templates:

Test runner to automatically test your entire Storybook and catch broken stories.
Visual tests capture a screenshot of every story then compare it against baselines to detect appearance and integration issues
Accessibility tests catch usability issues related to visual, hearing, mobility, cognitive, speech, or neurological disabilities
Interaction tests verify component functionality by simulating user behaviour, firing events, and ensuring that state is updated as expected
Snapshot tests detect changes in the rendered markup to surface rendering errors or warnings
Import stories in other tests to QA even more UI characteristics

We are already doing accessibility and we might want to do only visual and snapshot testing. For visual testing we will need to start using chromatic but if storybook is the future of origami we might investigate chromatic as well.

@notlee notlee added the components Relates to an Origami component label Oct 11, 2022
@notlee notlee added the next planning Used to mark an issue to discuss in Origami's next planning session label Feb 22, 2023
@notlee
Copy link
Contributor

notlee commented Feb 22, 2023

Out TSX templates are used in production now, not just in demos. We should introduce tests (probably snapshot tests) to ensure that for given props we get the markup we expect. I've added a label to ensure we discuss this in our next planning session and prioritise against other work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components Relates to an Origami component next planning Used to mark an issue to discuss in Origami's next planning session
Projects
None yet
Development

No branches or pull requests

2 participants