Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus rings overlap alert messages. #942

Open
akomiqaia opened this issue Dec 22, 2022 · 2 comments
Open

focus rings overlap alert messages. #942

akomiqaia opened this issue Dec 22, 2022 · 2 comments
Labels
accessibility An accessibility issue design A dependency on design

Comments

@akomiqaia
Copy link
Contributor

There was some discussion about making an extra bit of space between the alert message and input element so focus ring would not obscure it.
Screenshot 2022-12-21 at 14 18 53
@akomiqaia akomiqaia added accessibility An accessibility issue design A dependency on design labels Dec 22, 2022
@akomiqaia akomiqaia mentioned this issue Dec 22, 2022
Merged
@notlee
Copy link
Contributor

notlee commented Jan 5, 2023

Note: In our demos there's no overlap but the focus ring does run right against the error message.

@notlee
Copy link
Contributor

notlee commented Jan 5, 2023

Also note the clipping of the focus ring overflow is a product specific issue and not related to o-overlay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility An accessibility issue design A dependency on design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notlee @akomiqaia