[BUG] v1.0.21getting update failed - Duplicate mount point: /database

[kerauno1]

Description

When checking for updates, one update failed. I've updated this image before successfully, so it must be a problem with v1.0.21. This was done on my nas server.

Steps to reproduce

click on "Check for updates"

Logs

no logs are captured.

Browser logs

Dockhand version

v1.0.21

Hawser version (if used)

No response

Connection mode

socket

Please confirm the following

• I have already searched for relevant existing issues and discussions before opening this report.
• I have updated the title field above with a concise description.

[cungureanu]

I have the same issue

[kerauno1]

The update works on my linux laptop.

[itsDNNS]

I can reproduce this on a Synology NAS as well, and in my case the source config is clean while Dockhand still fails with Duplicate mount point: /data during recreate.

Environment:

• DSM 7.3.2-86009 Update 1
• Docker 24.0.2 / API 1.43
• connection mode: socket
• Dockhand image: fnsys/dockhand:latest
• affected container: docsight

The affected container is a compose-managed stack container:

ComposeProject=docsight
ComposeFile=/volume1/docker/dockhand/stacks/docsight/compose.yaml
ComposeVersion=2.20.1

The stack file has only one /data mount and one /backup mount:

services:
  docsight:
    image: ghcr.io/itsdnns/docsight:latest
    container_name: docsight
    restart: unless-stopped
    ports:
      - "8765:8765"
    volumes:
      - docsis_data:/data
      - /volume1/Daten/Clouds/OneDrive/Dennis/z_Backups/DOCSight:/backup
    cap_add:
      - NET_RAW

volumes:
  docsis_data:
    name: docsight_docsis_data
    external: true

The currently running container is also clean according to docker inspect:

Binds=["/volume1/Daten/Clouds/OneDrive/Dennis/z_Backups/DOCSight:/backup:rw"]
Mounts=[
  {"Type":"bind","Destination":"/backup",...},
  {"Type":"volume","Name":"docsight_docsis_data","Destination":"/data",...}
]

But Dockhand fails when it tries to recreate the container during auto-update:

[EnvUpdateCheck]   Recreating container: docsight (image: ghcr.io/itsdnns/docsight:latest)
[EnvUpdateCheck]   Stopping container...
[EnvUpdateCheck]   Renaming old container...
[EnvUpdateCheck]   Creating new container...
[EnvUpdateCheck]   Create failed: Duplicate mount point: /data
[EnvUpdateCheck]   Rolling back: restoring old container...
[EnvUpdateCheck]   Failed to recreate container: Duplicate mount point: /data

So at least in this case, the duplicate /data is not present in the stack file and not present in the running container config. It seems to be introduced by Dockhand while building the recreate request.

If useful, I can provide the full docker inspect docsight output as well.

[kerauno1]

Oh, also I'm running beta version b9a0a4c4 soon to be v1.0.22

[itsDNNS]

Fix submitted in #765 — the root cause is that Dockhand reads volume mounts from both HostConfig.Binds and inspectData.Mounts without deduplication. When Docker reports the same destination in both (common with named volumes from docker-compose), the recreate creates duplicate mount points.

The PR adds a dedupe step that checks mount targets before adding them, with a regression test covering both the existing-target and missing-target cases.