Fixed boolean buffer overwrite mishap

pl752 · pl752 · commit 1c46f86beb4d · 2025-12-12T13:57:07.000+05:00
diff --git a/src/FirebirdSql.Data.FirebirdClient/Client/Managed/XdrReaderWriter.cs b/src/FirebirdSql.Data.FirebirdClient/Client/Managed/XdrReaderWriter.cs
@@ -34,6 +34,7 @@ sealed class XdrReaderWriter : IXdrReader, IXdrWriter
 	readonly Charset _charset;
 
 	byte[] _smallBuffer;
+	byte[] _boolbuffer;
 	const int StackallocThreshold = 1024;
 
 	public XdrReaderWriter(IDataProvider dataProvider, Charset charset)
@@ -42,6 +43,7 @@ public XdrReaderWriter(IDataProvider dataProvider, Charset charset)
 		_charset = charset;
 
 		_smallBuffer = new byte[8];
+		_boolbuffer = new byte[1];
 	}
 
 	public XdrReaderWriter(IDataProvider dataProvider)
@@ -450,9 +452,8 @@ public bool ReadBoolean()
 	}
 	public async ValueTask<bool> ReadBooleanAsync(CancellationToken cancellationToken = default)
 	{
-		await ReadBytesAsync(_smallBuffer, 1, cancellationToken).ConfigureAwait(false);
-		await ReadPadAsync((4 - 1) & 3, cancellationToken).ConfigureAwait(false);
-		return TypeDecoder.DecodeBoolean(_smallBuffer);
+		await ReadOpaqueAsync(_boolbuffer, 1, cancellationToken).ConfigureAwait(false);
+		return TypeDecoder.DecodeBoolean(_boolbuffer);
 	}
 
 	public FbZonedDateTime ReadZonedDateTime(bool isExtended)

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ sealed class XdrReaderWriter : IXdrReader, IXdrWriter`
`34`	`34`	`readonly Charset _charset;`
`35`	`35`
`36`	`36`	`byte[] _smallBuffer;`
	`37`	`+ byte[] _boolbuffer;`
`37`	`38`	`const int StackallocThreshold = 1024;`
`38`	`39`
`39`	`40`	`public XdrReaderWriter(IDataProvider dataProvider, Charset charset)`
`@@ -42,6 +43,7 @@ public XdrReaderWriter(IDataProvider dataProvider, Charset charset)`
`42`	`43`	`_charset = charset;`
`43`	`44`
`44`	`45`	`_smallBuffer = new byte[8];`
	`46`	`+ _boolbuffer = new byte[1];`
`45`	`47`	`}`
`46`	`48`
`47`	`49`	`public XdrReaderWriter(IDataProvider dataProvider)`
`@@ -450,9 +452,8 @@ public bool ReadBoolean()`
`450`	`452`	`}`
`451`	`453`	`public async ValueTask<bool> ReadBooleanAsync(CancellationToken cancellationToken = default)`
`452`	`454`	`{`
`453`		`- await ReadBytesAsync(_smallBuffer, 1, cancellationToken).ConfigureAwait(false);`
`454`		`- await ReadPadAsync((4 - 1) & 3, cancellationToken).ConfigureAwait(false);`
`455`		`- return TypeDecoder.DecodeBoolean(_smallBuffer);`
	`455`	`+ await ReadOpaqueAsync(_boolbuffer, 1, cancellationToken).ConfigureAwait(false);`
	`456`	`+ return TypeDecoder.DecodeBoolean(_boolbuffer);`
`456`	`457`	`}`
`457`	`458`
`458`	`459`	`public FbZonedDateTime ReadZonedDateTime(bool isExtended)`