Elliminated some linq queries and allocations

pl752 · pl752 · commit c058fc583148 · 2025-12-11T11:15:22.000+05:00
diff --git a/src/FirebirdSql.Data.FirebirdClient/Client/Managed/GdsConnection.cs b/src/FirebirdSql.Data.FirebirdClient/Client/Managed/GdsConnection.cs
@@ -216,7 +216,7 @@ public void Identify(string database)
 							break;
 						}
 
-						if (AuthBlock.ServerKeys.Any())
+						if (AuthBlock.ServerKeys.Length > 0)
 						{
 							AuthBlock.SendWireCryptToBuffer();
 							Xdr.Flush();
@@ -330,7 +330,7 @@ await Xdr.ReadBooleanAsync(cancellationToken).ConfigureAwait(false),
 							break;
 						}
 
-						if (AuthBlock.ServerKeys.Any())
+						if (AuthBlock.ServerKeys.Length > 0)
 						{
 							await AuthBlock.SendWireCryptToBufferAsync(cancellationToken).ConfigureAwait(false);
 							await Xdr.FlushAsync(cancellationToken).ConfigureAwait(false);
diff --git a/src/FirebirdSql.Data.FirebirdClient/Client/Managed/Version13/GdsDatabase.cs b/src/FirebirdSql.Data.FirebirdClient/Client/Managed/Version13/GdsDatabase.cs
@@ -51,7 +51,7 @@ public override void Attach(DatabaseParameterBufferBase dpb, string database, by
 				var genericResponse = (GenericResponse)response;
 				ProcessAttachResponse(genericResponse);
 
-				if (genericResponse.Data.Any())
+				if (genericResponse.Data.Length > 0)
 				{
 					AuthBlock.SendWireCryptToBuffer();
 					Xdr.Flush();
@@ -100,7 +100,7 @@ public override async ValueTask AttachAsync(DatabaseParameterBufferBase dpb, str
 				var genericResponse = (GenericResponse)response;
 				await ProcessAttachResponseAsync(genericResponse, cancellationToken).ConfigureAwait(false);
 
-				if (genericResponse.Data.Any())
+				if (genericResponse.Data.Length > 0)
 				{
 					await AuthBlock.SendWireCryptToBufferAsync(cancellationToken).ConfigureAwait(false);
 					await Xdr.FlushAsync(cancellationToken).ConfigureAwait(false);
@@ -183,7 +183,7 @@ public override void CreateDatabase(DatabaseParameterBufferBase dpb, string data
 				var genericResponse = (GenericResponse)response;
 				ProcessCreateResponse(genericResponse);
 
-				if (genericResponse.Data.Any())
+				if (genericResponse.Data.Length > 0)
 				{
 					AuthBlock.SendWireCryptToBuffer();
 					Xdr.Flush();
@@ -223,7 +223,7 @@ public override async ValueTask CreateDatabaseAsync(DatabaseParameterBufferBase
 				var genericResponse = (GenericResponse)response;
 				await ProcessCreateResponseAsync(genericResponse, cancellationToken).ConfigureAwait(false);
 
-				if (genericResponse.Data.Any())
+				if (genericResponse.Data.Length > 0)
 				{
 					await AuthBlock.SendWireCryptToBufferAsync(cancellationToken).ConfigureAwait(false);
 					await Xdr.FlushAsync(cancellationToken).ConfigureAwait(false);
diff --git a/src/FirebirdSql.Data.FirebirdClient/Client/Managed/Version13/GdsServiceManager.cs b/src/FirebirdSql.Data.FirebirdClient/Client/Managed/Version13/GdsServiceManager.cs
@@ -52,7 +52,7 @@ public override void Attach(ServiceParameterBufferBase spb, string dataSource, i
 				var genericResponse = (GenericResponse)response;
 				base.ProcessAttachResponse(genericResponse);
 
-				if (genericResponse.Data.Any())
+				if (genericResponse.Data.Length > 0)
 				{
 					Database.AuthBlock.SendWireCryptToBuffer();
 					Database.Xdr.Flush();
@@ -98,7 +98,7 @@ public override async ValueTask AttachAsync(ServiceParameterBufferBase spb, stri
 				var genericResponse = (GenericResponse)response;
 				await base.ProcessAttachResponseAsync(genericResponse, cancellationToken).ConfigureAwait(false);
 
-				if (genericResponse.Data.Any())
+				if (genericResponse.Data.Length > 0)
 				{
 					await Database.AuthBlock.SendWireCryptToBufferAsync(cancellationToken).ConfigureAwait(false);
 					await Database.Xdr.FlushAsync(cancellationToken).ConfigureAwait(false);
diff --git a/src/FirebirdSql.Data.FirebirdClient/Client/Managed/Version16/GdsBatch.cs b/src/FirebirdSql.Data.FirebirdClient/Client/Managed/Version16/GdsBatch.cs
@@ -145,13 +145,21 @@ public override async ValueTask<ExecuteResultItem[]> ExecuteAsync(int count, IDe
 
 	public override int ComputeBatchSize(int count, IDescriptorFiller descriptorFiller)
 	{
-		var parametersData = GetParametersData(count, descriptorFiller);
-		return parametersData.Sum(x => x.Length);
+		var total = 0;
+		for(var i = 0; i < count; i++) {
+			var item = _statement.GetParameterData(descriptorFiller, i);
+			total += item.Length;
+		}
+		return total;
 	}
 	public override async ValueTask<int> ComputeBatchSizeAsync(int count, IDescriptorFiller descriptorFiller, CancellationToken cancellationToken = default)
 	{
-		var parametersData = await GetParametersDataAsync(count, descriptorFiller, cancellationToken).ConfigureAwait(false);
-		return parametersData.Sum(x => x.Length);
+		var total = 0;
+		for(var i = 0; i < count; i++) {
+			var item = await _statement.GetParameterDataAsync(descriptorFiller, i, cancellationToken).ConfigureAwait(false);
+			total += item.Length;
+		}
+		return total;
 	}
 
 	public override void Release()

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ public void Identify(string database)`
`216`	`216`	`break;`
`217`	`217`	`}`
`218`	`218`
`219`		`- if (AuthBlock.ServerKeys.Any())`
	`219`	`+ if (AuthBlock.ServerKeys.Length > 0)`
`220`	`220`	`{`
`221`	`221`	`AuthBlock.SendWireCryptToBuffer();`
`222`	`222`	`Xdr.Flush();`
`@@ -330,7 +330,7 @@ await Xdr.ReadBooleanAsync(cancellationToken).ConfigureAwait(false),`
`330`	`330`	`break;`
`331`	`331`	`}`
`332`	`332`
`333`		`- if (AuthBlock.ServerKeys.Any())`
	`333`	`+ if (AuthBlock.ServerKeys.Length > 0)`
`334`	`334`	`{`
`335`	`335`	`await AuthBlock.SendWireCryptToBufferAsync(cancellationToken).ConfigureAwait(false);`
`336`	`336`	`await Xdr.FlushAsync(cancellationToken).ConfigureAwait(false);`
Original file line number	Diff line number	Diff line change
`@@ -145,13 +145,21 @@ public override async ValueTask<ExecuteResultItem[]> ExecuteAsync(int count, IDe`
`145`	`145`
`146`	`146`	`public override int ComputeBatchSize(int count, IDescriptorFiller descriptorFiller)`
`147`	`147`	`{`
`148`		`- var parametersData = GetParametersData(count, descriptorFiller);`
`149`		`- return parametersData.Sum(x => x.Length);`
	`148`	`+ var total = 0;`
	`149`	`+ for(var i = 0; i < count; i++) {`
	`150`	`+ var item = _statement.GetParameterData(descriptorFiller, i);`
	`151`	`+ total += item.Length;`
	`152`	`+ }`
	`153`	`+ return total;`
`150`	`154`	`}`
`151`	`155`	`public override async ValueTask<int> ComputeBatchSizeAsync(int count, IDescriptorFiller descriptorFiller, CancellationToken cancellationToken = default)`
`152`	`156`	`{`
`153`		`- var parametersData = await GetParametersDataAsync(count, descriptorFiller, cancellationToken).ConfigureAwait(false);`
`154`		`- return parametersData.Sum(x => x.Length);`
	`157`	`+ var total = 0;`
	`158`	`+ for(var i = 0; i < count; i++) {`
	`159`	`+ var item = await _statement.GetParameterDataAsync(descriptorFiller, i, cancellationToken).ConfigureAwait(false);`
	`160`	`+ total += item.Length;`
	`161`	`+ }`
	`162`	`+ return total;`
`155`	`163`	`}`
`156`	`164`
`157`	`165`	`public override void Release()`