refactor(test): use vitest globalSetup for build instead of per-test builds

TabishB · TabishB · commit 57216a78240e · 2025-09-07T02:16:17.000+10:00
diff --git a/test/commands/change.interactive-show.test.ts b/test/commands/change.interactive-show.test.ts
@@ -1,6 +1,5 @@
-import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
-import { ensureBuild } from '../helpers/ensure-build.js';
 import path from 'path';
 import { execSync } from 'child_process';
 
@@ -10,9 +9,6 @@ describe('change show (interactive behavior)', () => {
   const changesDir = path.join(testDir, 'openspec', 'changes');
   const bin = path.join(projectRoot, 'bin', 'openspec.js');
 
-  beforeAll(() => {
-    ensureBuild();
-  });
 
   beforeEach(async () => {
     await fs.mkdir(changesDir, { recursive: true });
diff --git a/test/commands/change.interactive-validate.test.ts b/test/commands/change.interactive-validate.test.ts
@@ -1,6 +1,5 @@
-import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
-import { ensureBuild } from '../helpers/ensure-build.js';
 import path from 'path';
 import { execSync } from 'child_process';
 
@@ -13,9 +12,6 @@ describe('change validate (interactive behavior)', () => {
   const changesDir = path.join(testDir, 'openspec', 'changes');
   const bin = path.join(projectRoot, 'bin', 'openspec.js');
 
-  beforeAll(() => {
-    ensureBuild();
-  });
 
   beforeEach(async () => {
     await fs.mkdir(changesDir, { recursive: true });
diff --git a/test/commands/show.test.ts b/test/commands/show.test.ts
@@ -1,8 +1,7 @@
-import { describe, it, expect, beforeEach, afterEach, beforeAll } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
 import path from 'path';
 import { execSync } from 'child_process';
-import { ensureBuild } from '../helpers/ensure-build.js';
 
 describe('top-level show command', () => {
   const projectRoot = process.cwd();
@@ -11,9 +10,6 @@ describe('top-level show command', () => {
   const specsDir = path.join(testDir, 'openspec', 'specs');
   const openspecBin = path.join(projectRoot, 'bin', 'openspec.js');
 
-  beforeAll(() => {
-    ensureBuild();
-  });
 
   beforeEach(async () => {
     await fs.mkdir(changesDir, { recursive: true });
diff --git a/test/commands/spec.interactive-show.test.ts b/test/commands/spec.interactive-show.test.ts
@@ -1,6 +1,5 @@
-import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
-import { ensureBuild } from '../helpers/ensure-build.js';
 import path from 'path';
 import { execSync } from 'child_process';
 
@@ -10,9 +9,6 @@ describe('spec show (interactive behavior)', () => {
   const specsDir = path.join(testDir, 'openspec', 'specs');
   const bin = path.join(projectRoot, 'bin', 'openspec.js');
 
-  beforeAll(() => {
-    ensureBuild();
-  });
 
   beforeEach(async () => {
     await fs.mkdir(specsDir, { recursive: true });
diff --git a/test/commands/spec.interactive-validate.test.ts b/test/commands/spec.interactive-validate.test.ts
@@ -1,6 +1,5 @@
-import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
-import { ensureBuild } from '../helpers/ensure-build.js';
 import path from 'path';
 import { execSync } from 'child_process';
 
@@ -10,9 +9,6 @@ describe('spec validate (interactive behavior)', () => {
   const specsDir = path.join(testDir, 'openspec', 'specs');
   const bin = path.join(projectRoot, 'bin', 'openspec.js');
 
-  beforeAll(() => {
-    ensureBuild();
-  });
 
   beforeEach(async () => {
     await fs.mkdir(specsDir, { recursive: true });
diff --git a/test/commands/spec.test.ts b/test/commands/spec.test.ts
@@ -1,19 +1,14 @@
-import { describe, it, expect, beforeEach, afterEach, beforeAll } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
 import path from 'path';
 import { execSync } from 'child_process';
-import { ensureBuild } from '../helpers/ensure-build.js';
 
 describe('spec command', () => {
   const projectRoot = process.cwd();
   const testDir = path.join(projectRoot, 'test-spec-command-tmp');
   const specsDir = path.join(testDir, 'openspec', 'specs');
   const openspecBin = path.join(projectRoot, 'bin', 'openspec.js');
   
-  beforeAll(() => {
-    // Ensure CLI is built so bin/openspec.js loads latest logic from dist/
-    ensureBuild();
-  });
   
   beforeEach(async () => {
     await fs.mkdir(specsDir, { recursive: true });
diff --git a/test/commands/validate.enriched-output.test.ts b/test/commands/validate.enriched-output.test.ts
@@ -1,6 +1,5 @@
-import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
-import { ensureBuild } from '../helpers/ensure-build.js';
 import path from 'path';
 import { execSync } from 'child_process';
 
@@ -10,10 +9,6 @@ describe('validate command enriched human output', () => {
   const changesDir = path.join(testDir, 'openspec', 'changes');
   const bin = path.join(projectRoot, 'bin', 'openspec.js');
 
-  beforeAll(() => {
-    // Build once so the bin can resolve dist
-    try { ensureBuild(); } catch {}
-  });
 
   beforeEach(async () => {
     await fs.mkdir(changesDir, { recursive: true });
diff --git a/test/commands/validate.test.ts b/test/commands/validate.test.ts
@@ -1,6 +1,5 @@
-import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
 import { promises as fs } from 'fs';
-import { ensureBuild } from '../helpers/ensure-build.js';
 import path from 'path';
 import { execSync } from 'child_process';
 
@@ -11,9 +10,6 @@ describe('top-level validate command', () => {
   const specsDir = path.join(testDir, 'openspec', 'specs');
   const bin = path.join(projectRoot, 'bin', 'openspec.js');
 
-  beforeAll(() => {
-    ensureBuild();
-  });
 
   beforeEach(async () => {
     await fs.mkdir(changesDir, { recursive: true });
diff --git a/test/helpers/ensure-build.ts b/test/helpers/ensure-build.ts
diff --git a/vitest.config.ts b/vitest.config.ts
@@ -4,6 +4,7 @@ export default defineConfig({
   test: {
     globals: true,
     environment: 'node',
+    globalSetup: './vitest.setup.ts',
     // Keep default pool settings; some tests rely on process.chdir,
     // which is not supported in worker threads
     include: ['test/**/*.test.ts'],
diff --git a/vitest.setup.ts b/vitest.setup.ts
@@ -0,0 +1,21 @@
+import { execSync } from 'child_process';
+import { existsSync } from 'fs';
+import path from 'path';
+
+// Run once before all tests
+export async function setup() {
+  const distPath = path.join(process.cwd(), 'dist', 'cli', 'index.js');
+  
+  if (!existsSync(distPath)) {
+    console.log('Building project before tests...');
+    try {
+      execSync('pnpm run build', { 
+        stdio: 'inherit',
+        cwd: process.cwd()
+      });
+    } catch (error) {
+      console.error('Failed to build project:', error);
+      process.exit(1);
+    }
+  }
+}
