Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actual Shard Times Outputting despite Output Style Changes #2239

Open
WillPRally opened this issue Apr 4, 2022 · 1 comment
Open

Actual Shard Times Outputting despite Output Style Changes #2239

WillPRally opened this issue Apr 4, 2022 · 1 comment
Labels

Comments

@WillPRally
Copy link

WillPRally commented Apr 4, 2022

Describe the bug
The actual shard times Shard 1: Expected: 0s, Actual: 3s, Diff: 3s is outputting in the console even though I have output style set to either single or compact. This is impacting readability on our output in circleci.

To Reproduce
firebase test android run

Expected behavior
I was expecting just the results section specified here: https://github.com/Flank/flank/blob/master/docs/flank-output-investigation/flank_current_output.md and that's it.

Details (please complete the following information):
I'm running flank on CircleCi and uploaded the latest flank snapshot from the documentation there

Additional context
Not super familiar with Flank, picking up from someone else's work. If this isn't a bug or might be a config issue, let me know steps to resolve

@WillPRally WillPRally added the Bug label Apr 4, 2022
@SelaseKay
Copy link
Collaborator

SelaseKay commented Nov 22, 2024

Hi @WillPRally, thank you for bringing this up. The output-style options (single or compact) control the formatting of results but don’t remove shard timing details. According to the docs, compact reduces detail but still includes essential info like test counts and results, which may include shard times as far as I know. I believe the current flank_current_output.md is outdated and needs to be modified to include Actual shard times section.

If possible, could you share a screenshot of your CircleCI output for clarity?

@SelaseKay SelaseKay added Feature and removed Bug labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants