Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave only one json library in deps (jsonista or data.json) #221

Open
soulflyer opened this issue Jul 1, 2022 · 2 comments
Open

Leave only one json library in deps (jsonista or data.json) #221

soulflyer opened this issue Jul 1, 2022 · 2 comments
Assignees
Labels
0.5.0 for release 0.5.0

Comments

@soulflyer
Copy link
Contributor

soulflyer commented Jul 1, 2022

First check which of the 2 json decoding libraries is the best to use. Feeling is that jsonista is the best choice but confirm this before proceeding.
https://www.juxt.pro/blog/json-in-clojure

@soulflyer soulflyer added the 0.5.0 for release 0.5.0 label Jul 8, 2022
@a-luz
Copy link
Contributor

a-luz commented Jul 13, 2022

This will be solved together with #220. When I finish removing lein from the project I'll remove one of those two libraries

@soulflyer
Copy link
Contributor Author

soulflyer commented Jul 28, 2023

Both are still present, but jsonista is not there in the deps.edn file.
We should attempt to remove data.json as it is only used for simple read and write calls in xiana/db.clj
(There are other occurrences in the examples)
jsonista should be added to deps.edn and data.json removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.5.0 for release 0.5.0
Projects
None yet
Development

No branches or pull requests

3 participants