Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misplaced test-container dependency declaration #225

Open
soulflyer opened this issue Jul 13, 2022 · 2 comments
Open

Misplaced test-container dependency declaration #225

soulflyer opened this issue Jul 13, 2022 · 2 comments
Assignees
@gmsvalente
Labels
0.5.0 for release 0.5.0 good first issue Good for newcomers

Comments

@soulflyer
Copy link
Contributor

Xiana should not force its clients to depend on testcontainers. This is declared in the main dependancies section of project.clj and should be only in test.
@soulflyer soulflyer added good first issue Good for newcomers 0.5.0 for release 0.5.0 labels Jul 13, 2022
@petervlk
Copy link

Related #175

@g-krisztian
Copy link
Collaborator

g-krisztian commented Sep 21, 2022 •
edited
Loading

I've deleted the PR for #175, and created #233

@gmsvalente gmsvalente self-assigned this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmsvalente gmsvalente

Labels
0.5.0 for release 0.5.0 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@soulflyer @petervlk @g-krisztian @gmsvalente