Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to sort if has default options #3

Open
Noitidart opened this issue Jul 13, 2017 · 4 comments
Open

Unable to sort if has default options #3

Noitidart opened this issue Jul 13, 2017 · 4 comments

Comments

@Noitidart
Copy link

In javascript lots of times we have default values for arguments, something like this:

function({ foo, bar, qux=8, baz=9 })

Some people put spaces between the ='s sign.

If I highlight within the curlies and try to sort it fails. :(

@FlorianWendelborn
Copy link
Owner

FlorianWendelborn commented Jul 14, 2017

I guess I'll have to implement an AST parser.

@Noitidart
Copy link
Author

Thank you sir so much for your willingness to address this! I am super excited. I switched from Atom to VSCode, but am now switching back to Atom/Nuclide and am mising this sort feature I used to use on VSCode - https://github.com/henriiik/vscode-sort

@FlorianWendelborn
Copy link
Owner

@Noitidart I'm very busy with university and my job right now, don't expect this too quickly without a PR. I still want to do it (partly because I always wanted to implement a parser) but no idea when I'll find time as this issue isn't trivial to fix.

@Noitidart
Copy link
Author

No problem, I really appreicate your note sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants