Add support for deferred components #576
Conversation
ianmaciel
requested review from
wasabeef,
AlexV525 and
lcdsmao
as code owners
| }); | ||
|
|
||
| // Merge the deferred assets with the main assets. | ||
| return [...config.pubspec.flutter.assets, ...deferredAssets]; |
There was a problem hiding this comment.
Wouldn't [...?config.pubspec.flutter.deferredAssets?.assets] do the same thing as above?
There was a problem hiding this comment.
That's true...! good catch!
I actually don't need the forEach loop, just need to merge the two lists.
BTW, do you mean?
There was a problem hiding this comment.
I'm sorry. For a moment I thought it was the same but it is not. I need to revert it.
The fact is we may have many Deferret Components, with many assets each (a list of lists).
So before spreading the list of deferredComponents, it is necessary to spread the assets from each deferredComponent
There was a problem hiding this comment.
So you may reduce components' assets into one?
There was a problem hiding this comment.
I didn't get that. 🤔
What do you mean by reduce components assets?
There was a problem hiding this comment.
Something like reduce((list, assets) => list + assets)
There was a problem hiding this comment.
I belive I'd need to use fold instead of reduce to have an initial empty list (I might have nothing at this point):
So I got something like this:
|
Also we need a test to make sure it works well |
|
Hi @AlexV525, I pushed fixups for this pr, if this is okay please let me know so can rebase squashing those fixups. |
|
Changes are good but still missing tests. You don't need to squash them as we'll squash them to commit eventually. |
ianmaciel
force-pushed
the
feature/add-support-for-deferred-components
branch
from
859d10e
to
564f01b
Compare
What does this change?
This PR include support for Flutter Deferred Components.
Deferred components allow developers to the app into multiple apk to reduce its size. This can be used to optimize the initial download and download components only on necessary but it is also mandatory for apk with more than 200MB.
This library initially looks for assets listed on
flutter.assetsofpubspec.yaml, with this change the library will continue looking for the assets lists underflutter.assetsbut will merge with the list of assets included onflutter.deferred-components.$. This will be merged in a single list.Ideally in the future assets should have different classname, so users will easily know when dealing with deferred components. This wasn't implemented at this moment because it would requeire a significative changes.
Fixes #577 🎯
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test)melos run formatto automatically apply formatting)