Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs, demo and rectify signs #18

Closed
1 of 2 tasks
SomTambe opened this issue Aug 11, 2021 · 2 comments
Closed
1 of 2 tasks

Add docs, demo and rectify signs #18

SomTambe opened this issue Aug 11, 2021 · 2 comments

Comments

@SomTambe
Copy link
Member

SomTambe commented Aug 11, 2021

We need a demo for the homography training example. This should be added as a part of the docs.
We currently have a sign problem. The gradients calculated by AD and the hand written gradients have exactly opposite signs. There needs to be a fix for this, and I'll have a better idea where the sign is going wrong when I write the demo using DiffImages. I already checked the individual gradients in the pipeline - there was no problem with them and the tests for all the rules are passing. There is a small quirk, and that I will figure out.

  • Add demo to the docs
  • Rectify the sign problem.
@DhairyaLGandhi
Copy link
Member

Last piece of the puzzle for #12 ?

@SomTambe
Copy link
Member Author

Yes, last piece of the puzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants