Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Merge on wren_social_data with Remote Theme Fails #31

Open
Foggalong opened this issue Sep 12, 2021 · 0 comments
Open

Config Merge on wren_social_data with Remote Theme Fails #31

Foggalong opened this issue Sep 12, 2021 · 0 comments
Labels
Milestone

Comments

@Foggalong
Copy link
Owner

Describe the bug
The wren_social_data YAML in the theme's config isn't merged into the user's config when they're using Wren through jekyll-remote-theme remotely.

To Reproduce
Steps to reproduce the behaviour:

  1. Set remote theme: jekyll-wren
  2. Remove wren_social_data from _config.yml
  3. Scroll down to footer
  4. See broken social buttons

Expected behaviour
Would expect Jekyll to pick up the wren_social_data YAML from the theme's config so that the user doesn't have to have the data saved in theirs. This happen if using Wren's gem but not when using the theme remotely.

@Foggalong Foggalong added the bug label Sep 12, 2021
@Foggalong Foggalong added this to the v0.5 milestone Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant