Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The LianaOption "expressParentApp" is not described in the library's types #1084

Open
vinassefranche opened this issue Jun 20, 2023 · 2 comments · May be fixed by #1088
Open

The LianaOption "expressParentApp" is not described in the library's types #1084

vinassefranche opened this issue Jun 20, 2023 · 2 comments · May be fixed by #1088

Comments

@vinassefranche
Copy link

Expected behavior

I would like to be able to set the expressParentApp option when I call the init function without TypeScript telling me:
Object literal may only specify known properties, and 'expressParentApp' does not exist in type 'LianaOptions'.

Actual behavior

TypeScript tells me:
Object literal may only specify known properties, and 'expressParentApp' does not exist in type 'LianaOptions'.

Failure Logs

N/A

Context

TODO: Please provide any relevant information about your setup.

  • Package Version: 9.2.10
  • Express Version: 4.18.2
  • Sequelize Version: 6.32.0
  • Database Dialect: N/A
  • Database Version: N/A
@Thenkei
Copy link
Contributor

Thenkei commented Jul 7, 2023

I just check and you are right. We export type through a public repository Definitely Typed
It is a project that provides a central repository of TypeScript definitions for NPM packages which do not have types like this one. You can open a Pull Request on this repository to contribute to our project if you wish. 🙏

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/57b1cd2e7aef45d6ca5cb8e0fad99e445bd581c6/types/forest-express-sequelize/index.d.ts#L4

@vinassefranche
Copy link
Author

Hi @Thenkei !

I'm perfectly ok with opening a P.R. for this.

However, the types I see in my code base are the ones from this repository (this file) so doing a P.R. on DefinitelyTyped would not fix my issue.

I'm a bit surprised that you are maintaining the types (with some differences) there and in this repository. Any reason for that? To me, as long as you have the types in the main repository, it's useless to have the DefinitelyTyped ones.

I can also open a P.R. on both repositories if you think I should.

Thanks for your answers anyway!

@vinassefranche vinassefranche linked a pull request Jul 10, 2023 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Thenkei @vinassefranche