Skip to content

Commit c22ea7f

Browse files
authored
engines node version (#217)
* engines node version * packagemanger version * upgrade action version per docs * rm packagemanger version * versions * upgrades * versioning * version formatting issue * try to just reinstall * install * word
1 parent bfe528c commit c22ea7f

File tree

3 files changed

+17
-10
lines changed

3 files changed

+17
-10
lines changed

.github/workflows/code-check.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ jobs:
1414
name: "Check codebase (lint and typecheck)"
1515
runs-on: ubuntu-latest
1616
steps:
17-
- uses: actions/checkout@v2
17+
- uses: actions/checkout@v4
1818
- uses: actions/setup-node@v2
1919
with:
2020
node-version: 18.x
2121

22-
- uses: pnpm/action-setup@v2.2.2
22+
- uses: pnpm/action-setup@v4
2323
with:
24-
version: 8
24+
version: 8.15.9
2525

2626
- name: "Get pnpm store directory"
2727
id: pnpm-cache
@@ -48,16 +48,16 @@ jobs:
4848
name: "Unit Tests"
4949
runs-on: ubuntu-latest
5050
steps:
51-
- uses: actions/checkout@v2
51+
- uses: actions/checkout@v4
5252
with:
5353
fetch-depth: 0
5454
- uses: actions/setup-node@v2
5555
with:
5656
node-version: 18.x
5757

58-
- uses: pnpm/action-setup@v2.2.2
58+
- uses: pnpm/action-setup@v4
5959
with:
60-
version: 8
60+
version: 8.15.9
6161

6262
- name: "Get pnpm store directory"
6363
id: pnpm-cache

.github/workflows/e2e-tests.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ jobs:
1616
name: E2E Tests
1717
runs-on: ubuntu-latest
1818
steps:
19-
- uses: actions/checkout@v2
20-
- uses: actions/setup-node@v2
19+
- uses: actions/checkout@v4
20+
- uses: actions/setup-node@v4
2121
with:
2222
node-version: 18.x
2323

24-
- uses: pnpm/action-setup@v2.2.2
24+
- uses: pnpm/action-setup@v4
2525
with:
26-
version: 8
26+
version: 8.15.9
2727

2828
- name: Get pnpm store directory
2929
id: pnpm-cache
@@ -56,6 +56,10 @@ jobs:
5656
working-directory: packages/shared-ui
5757
run: pnpm build
5858

59+
- name: Reinstall Binary # should probably get cache working if this project is revitalized
60+
run: npx cypress install
61+
working-directory: "packages/tests-e2e"
62+
5963
- name: Cypress Run (Production Backend)
6064
run: pnpm run test:e2e-real:start
6165
# - name: Cypress Run (Mock Backend)

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,8 @@
5656
"*.{js,jsx,ts,tsx,css,md,json}": [
5757
"prettier --write"
5858
]
59+
},
60+
"engines": {
61+
"node": ">=18.0.0"
5962
}
6063
}

0 commit comments

Comments
 (0)