When using custom axis the timestamps don't get formatted

[Kalhama]

Is there an existing issue for this?

• I have searched the existing issues

Code of Conduct

• I agree to follow this project's Code of Conduct

Victory version

latest

Code Sandbox link

https://codesandbox.io/p/sandbox/victory-starter-forked-5yzzn2

Bug report

When using custom axes the timestamps don't get formatted. The default axes pick good tick values, and tickformat is very nice with major value changes getting more attention. However in my application I need to adjust the axes a bit (namely offsetY={50}) and thus I lose access to those nice features.

Steps to reproduce

In the sandbox there are two graphs that I except to render same thing.

Expected behavior

I think expected behavior is to render the same axis in both scenarios. Alternatively provide a functions that default exis uses for selecting and formatting ticks, so that I can pass then on.

Actual behavior

Chart using custom axes doesn't format or pick good timestamp values

Environment

- Device: Firefox
- OS: MacOS
- Node: 20
- npm: N/A

[Kalhama]

[Kalhama]

Victory uses d3 in the background for this feature. In custom axis you can use the d3 functionality like this.

// import * as d3 from 'd3'

const domain = {
  x: [Math.min(...data.map(d => d.x)), Math.max(...data.map(d => d.x))] as DomainTuple<Date>
}

var timeScaledomain = d3.scaleTime().domain(domain.x) // or zoomDomain.x, if you're using ZoomContainer
const ticks = timeScaledomain.ticks(5)
const formatter = timeScaledomain.tickFormat()

return (
  <VictoryAxis
    tickValues={ticks}
    tickFormat={formatter}
    offsetY={50}
  />
  <VictoryAxis
    crossAxis={false}
    dependentAxis
  />
 )

i will not close the issue.as I don't know whether requiring this workaround is a intended functionality of Victory

[carbonrobot]

Closing for now, as this is by design, but will add notes to our documentation.