-
Notifications
You must be signed in to change notification settings - Fork 84
/
Copy pathoperator_test.go
2734 lines (2309 loc) · 97.9 KB
/
operator_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
* operator_test.go
*
* This source file is part of the FoundationDB open source project
*
* Copyright 2023 Apple Inc. and the FoundationDB project authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package operator
/*
This test suite includes functional tests to ensure normal operational tasks are working fine.
Those tests include replacements of healthy or fault Pods and setting different configurations.
The assumption is that every test case reverts the changes that were done on the cluster.
In order to improve the test speed we only create one FoundationDB cluster initially.
This cluster will be used for all tests.
*/
import (
"bytes"
"context"
"encoding/binary"
"fmt"
"log"
"math"
"strings"
"time"
"github.com/apple/foundationdb/fdbkubernetesmonitor/api"
fdbv1beta2 "github.com/FoundationDB/fdb-kubernetes-operator/api/v1beta2"
"github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures"
"github.com/FoundationDB/fdb-kubernetes-operator/internal"
"github.com/FoundationDB/fdb-kubernetes-operator/pkg/fdbstatus"
chaosmesh "github.com/chaos-mesh/chaos-mesh/api/v1alpha1"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/utils/pointer"
ctrlClient "sigs.k8s.io/controller-runtime/pkg/client"
)
var (
factory *fixtures.Factory
fdbCluster *fixtures.FdbCluster
testOptions *fixtures.FactoryOptions
scheduleInjectPodKill *fixtures.ChaosMeshExperiment
)
func init() {
testOptions = fixtures.InitFlags()
}
func validateStorageClass(processClass fdbv1beta2.ProcessClass, targetStorageClass string) {
Eventually(func() map[string]fdbv1beta2.None {
storageClassNames := make(map[string]fdbv1beta2.None)
volumeClaims := fdbCluster.GetVolumeClaimsForProcesses(processClass)
for _, volumeClaim := range volumeClaims.Items {
storageClassNames[*volumeClaim.Spec.StorageClassName] = fdbv1beta2.None{}
}
return storageClassNames
}, 5*time.Minute).Should(Equal(map[string]fdbv1beta2.None{targetStorageClass: {}}))
}
var _ = BeforeSuite(func() {
factory = fixtures.CreateFactory(testOptions)
fdbCluster = factory.CreateFdbCluster(
fixtures.DefaultClusterConfig(false),
factory.GetClusterOptions()...,
)
// Make sure that the test suite is able to fetch logs from Pods.
operatorPod := factory.RandomPickOnePod(factory.GetOperatorPods(fdbCluster.Namespace()).Items)
Expect(factory.GetLogsForPod(&operatorPod, "manager", nil)).NotTo(BeEmpty())
// Load some data async into the cluster. We will only block as long as the Job is created.
factory.CreateDataLoaderIfAbsent(fdbCluster)
// In order to test the robustness of the operator we try to kill the operator Pods every minute.
if factory.ChaosTestsEnabled() {
scheduleInjectPodKill = factory.ScheduleInjectPodKillWithName(
fixtures.GetOperatorSelector(fdbCluster.Namespace()),
"*/2 * * * *",
chaosmesh.OneMode,
fdbCluster.Namespace()+"-"+fdbCluster.Name(),
)
}
})
var _ = AfterSuite(func() {
if CurrentSpecReport().Failed() {
log.Printf("failed due to %s", CurrentSpecReport().FailureMessage())
}
factory.Shutdown()
})
var _ = Describe("Operator", Label("e2e", "pr"), func() {
var availabilityCheck bool
AfterEach(func() {
// Reset availabilityCheck if a test case removes this check.
availabilityCheck = true
if CurrentSpecReport().Failed() {
factory.DumpState(fdbCluster)
}
Expect(fdbCluster.WaitForReconciliation()).ToNot(HaveOccurred())
factory.StopInvariantCheck()
// Make sure all data is present in the cluster
fdbCluster.EnsureTeamTrackersAreHealthy()
fdbCluster.EnsureTeamTrackersHaveMinReplicas()
})
JustBeforeEach(func() {
if availabilityCheck {
err := fdbCluster.InvariantClusterStatusAvailable()
Expect(err).NotTo(HaveOccurred())
}
})
PWhen("nodes in the cluster are tainted", func() {
taintKeyMaintenance := "maintenance"
taintKeyMaintenanceDuration := int64(2)
taintKeyStar := "*"
taintKeyStarDuration := int64(5)
var initialPods *corev1.PodList
var taintedNode *corev1.Node
var taintedNodes []*corev1.Node
historyTaintedNodes := make(map[string]fdbv1beta2.None)
numNodesTainted := 2 // TODO: Change to higher number 5
ensurePodIsDeletedTimeoutMinutes := 20
BeforeEach(func() {
// Cleanup tainted nodes in case previous test fails which will leave tainted nodes behind
for nodeName := range historyTaintedNodes {
log.Printf("BeforeEach Reset node as untainted:%s\n", nodeName)
node := fdbCluster.GetNode(nodeName)
node.Spec.Taints = []corev1.Taint{}
fdbCluster.UpdateNode(node)
}
initialPods = fdbCluster.GetStatelessPods()
// Setup cluster's taint config and wait for long enough
fdbCluster.SetClusterTaintConfig([]fdbv1beta2.TaintReplacementOption{
{
Key: &taintKeyMaintenance,
DurationInSeconds: &taintKeyMaintenanceDuration,
},
}, pointer.Int(1))
Expect(len(fdbCluster.GetCluster().Spec.AutomationOptions.Replacements.TaintReplacementOptions)).To(BeNumerically(">=", 1))
Expect(*fdbCluster.GetAutomationOptions().Replacements.Enabled).To(BeTrue())
})
AfterEach(func() {
Expect(fdbCluster.ClearProcessGroupsToRemove()).NotTo(HaveOccurred())
// Reset taint related options to default value in e2e test
fdbCluster.SetClusterTaintConfig([]fdbv1beta2.TaintReplacementOption{}, pointer.Int(150))
// untaint the nodes
log.Printf("AfterEach Cleanup: Untaint the single node:%s\n", taintedNode.Name)
historyTaintedNodes[taintedNode.Name] = fdbv1beta2.None{}
taintedNode = fdbCluster.GetNode(taintedNode.Name)
taintedNode.Spec.Taints = []corev1.Taint{}
fdbCluster.UpdateNode(taintedNode)
for i, node := range taintedNodes {
historyTaintedNodes[node.Name] = fdbv1beta2.None{}
log.Printf("Cleanup: Untaint the %dth node:%s\n", i, node.Name)
node = fdbCluster.GetNode(node.Name)
node.Spec.Taints = []corev1.Taint{}
fdbCluster.UpdateNode(node)
}
taintedNodes = []*corev1.Node{}
})
When("cluster enables taint feature on focused maintenance taint key", func() {
It("should remove the targeted Pod whose Node is tainted", func() {
replacedPod := factory.RandomPickOnePod(initialPods.Items)
// Taint replacePod's node
taintedNode = fdbCluster.GetNode(replacedPod.Spec.NodeName)
taintedNode.Spec.Taints = []corev1.Taint{
{
Key: taintKeyMaintenance,
Value: "rack_maintenance",
Effect: corev1.TaintEffectPreferNoSchedule,
TimeAdded: &metav1.Time{Time: time.Now().Add(-time.Second * time.Duration(taintKeyMaintenanceDuration+1))},
},
}
log.Printf("Taint node: Pod name:%s Node name:%s Node taints:%+v TaintTime:%+v Now:%+v\n", replacedPod.Name,
taintedNode.Name, taintedNode.Spec.Taints, taintedNode.Spec.Taints[0].TimeAdded.Time, time.Now())
fdbCluster.UpdateNode(taintedNode)
err := fdbCluster.WaitForReconciliation()
Expect(err).NotTo(HaveOccurred())
fdbCluster.EnsurePodIsDeletedWithCustomTimeout(replacedPod.Name, ensurePodIsDeletedTimeoutMinutes)
})
It("should remove all Pods whose Nodes are tainted", func() {
replacedPods := factory.RandomPickPod(initialPods.Items, numNodesTainted)
for _, pod := range replacedPods {
// Taint replacePod's node
node := fdbCluster.GetNode(pod.Spec.NodeName)
node.Spec.Taints = []corev1.Taint{
{
Key: taintKeyMaintenance,
Value: "rack_maintenance",
Effect: corev1.TaintEffectPreferNoSchedule,
TimeAdded: &metav1.Time{Time: time.Now().Add(-time.Millisecond * time.Duration(taintKeyMaintenanceDuration*1000+int64(factory.Intn(1000))))},
},
}
log.Printf("Taint node: Pod name:%s Node name:%s Node taints:%+v TaintTime:%+v Now:%+v\n", pod.Name,
node.Name, node.Spec.Taints, node.Spec.Taints[0].TimeAdded.Time, time.Now())
fdbCluster.UpdateNode(node)
taintedNodes = append(taintedNodes, node)
}
err := fdbCluster.WaitForReconciliation()
Expect(err).NotTo(HaveOccurred())
for i, pod := range replacedPods {
log.Printf("Ensure %dth pod:%s is deleted\n", i, pod.Name)
fdbCluster.EnsurePodIsDeletedWithCustomTimeout(pod.Name, ensurePodIsDeletedTimeoutMinutes)
}
})
})
When("cluster enables taint feature on star taint key", func() {
taintKeyMaintenanceDuration = int64(1)
taintKeyStar = "*"
taintKeyStarDuration = int64(5)
BeforeEach(func() {
// Custom TaintReplacementOptions to taintKeyStar
fdbCluster.SetClusterTaintConfig([]fdbv1beta2.TaintReplacementOption{
{
Key: &taintKeyStar,
DurationInSeconds: &taintKeyStarDuration,
},
}, pointer.Int(1))
automationOptions := fdbCluster.GetAutomationOptions()
Expect(len(automationOptions.Replacements.TaintReplacementOptions)).To(BeNumerically(">=", 1))
Expect(*automationOptions.Replacements.Enabled).To(BeTrue())
})
It("should eventually remove the targeted Pod whose Node is tainted", func() {
replacedPod := factory.RandomPickOnePod(initialPods.Items)
// Taint replacePod's node
node := fdbCluster.GetNode(replacedPod.Spec.NodeName)
node.Spec.Taints = []corev1.Taint{
{
Key: taintKeyMaintenance,
Value: "rack_maintenance",
Effect: corev1.TaintEffectPreferNoSchedule,
TimeAdded: &metav1.Time{Time: time.Now().Add(-time.Second * time.Duration(taintKeyMaintenanceDuration+1))},
},
}
log.Printf("Taint node: Pod name:%s Node name:%s Node taints:%+v TaintTime:%+v Now:%+v\n", replacedPod.Name,
node.Name, node.Spec.Taints, node.Spec.Taints[0].TimeAdded.Time, time.Now())
fdbCluster.UpdateNode(node)
err := fdbCluster.WaitForReconciliation()
Expect(err).NotTo(HaveOccurred())
fdbCluster.EnsurePodIsDeletedWithCustomTimeout(replacedPod.Name, ensurePodIsDeletedTimeoutMinutes)
})
It("should eventually remove all Pods whose Nodes are tainted", func() {
replacedPods := factory.RandomPickPod(initialPods.Items, numNodesTainted)
for _, pod := range replacedPods {
// Taint replacePod's node
node := fdbCluster.GetNode(pod.Spec.NodeName)
node.Spec.Taints = []corev1.Taint{
{
Key: taintKeyMaintenance,
Value: "rack_maintenance",
Effect: corev1.TaintEffectPreferNoSchedule,
TimeAdded: &metav1.Time{Time: time.Now().Add(-time.Millisecond * time.Duration(taintKeyStarDuration*1000+int64(factory.Intn(1000))))},
},
}
log.Printf("Taint node: Pod name:%s Node name:%s Node taints:%+v TaintTime:%+v Now:%+v\n", pod.Name,
node.Name, node.Spec.Taints, node.Spec.Taints[0].TimeAdded.Time, time.Now())
fdbCluster.UpdateNode(node)
}
err := fdbCluster.WaitForReconciliation()
Expect(err).NotTo(HaveOccurred())
for i, pod := range replacedPods {
log.Printf("Ensure %dth pod:%s is deleted\n", i, pod.Name)
fdbCluster.EnsurePodIsDeletedWithCustomTimeout(pod.Name, ensurePodIsDeletedTimeoutMinutes)
}
})
})
When("cluster disables taint feature with empty taint option", func() {
taintKeyMaintenanceDuration = int64(1)
taintKeyStar = "*"
BeforeEach(func() {
// Custom TaintReplacementOptions to taintKeyStar
fdbCluster.SetClusterTaintConfig([]fdbv1beta2.TaintReplacementOption{}, pointer.Int(1))
automationOptions := fdbCluster.GetAutomationOptions()
Expect(len(automationOptions.Replacements.TaintReplacementOptions)).To(BeNumerically("==", 0))
Expect(*automationOptions.Replacements.Enabled).To(BeTrue())
})
It("should not remove any Pod whose Nodes are tainted", func() {
targetPods := factory.RandomPickPod(initialPods.Items, numNodesTainted)
var targetPodProcessGroupIDs []fdbv1beta2.ProcessGroupID
for _, pod := range targetPods {
targetPodProcessGroupIDs = append(targetPodProcessGroupIDs, internal.GetProcessGroupIDFromMeta(fdbCluster.GetCluster(), pod.ObjectMeta))
// Taint replacePod's node
node := fdbCluster.GetNode(pod.Spec.NodeName)
node.Spec.Taints = []corev1.Taint{
{
Key: taintKeyMaintenance,
Value: "rack_maintenance",
Effect: corev1.TaintEffectPreferNoSchedule,
TimeAdded: &metav1.Time{Time: time.Now().Add(-time.Millisecond * time.Duration(taintKeyStarDuration*1000+int64(factory.Intn(1000))))},
},
}
log.Printf("Taint node: Pod name:%s Node name:%s Node taints:%+v TaintTime:%+v Now:%+v\n", pod.Name,
node.Name, node.Spec.Taints, node.Spec.Taints[0].TimeAdded.Time, time.Now())
fdbCluster.UpdateNode(node)
}
Consistently(func() bool {
for _, groupID := range targetPodProcessGroupIDs {
processGroupStatus := fdbv1beta2.FindProcessGroupByID(fdbCluster.GetCluster().Status.ProcessGroups, groupID)
Expect(processGroupStatus).NotTo(BeNil())
Expect(processGroupStatus.GetCondition(fdbv1beta2.NodeTaintDetected)).To(BeNil())
}
return true
}).WithTimeout(time.Duration(*fdbCluster.GetAutomationOptions().Replacements.TaintReplacementTimeSeconds-1) * time.Second).WithPolling(1 * time.Second).Should(BeTrue())
// Wait for operator to replace the pod
time.Sleep(time.Second * time.Duration(*fdbCluster.GetAutomationOptions().Replacements.TaintReplacementTimeSeconds+1))
err := fdbCluster.WaitForReconciliation()
Expect(err).NotTo(HaveOccurred())
for i, pod := range targetPods {
log.Printf("Ensure %dth pod:%s is not deleted\n", i, pod.Name)
deleted := fdbCluster.CheckPodIsDeleted(pod.Name)
Expect(deleted).To(BeFalse())
}
})
})
})
It("should set the fault domain for all process groups", func() {
for _, processGroup := range fdbCluster.GetCluster().Status.ProcessGroups {
Expect(processGroup.FaultDomain).NotTo(BeEmpty())
}
// TODO (johscheuer): We should check here further fields in the FoundationDBCluster resource to make sure the
// fields that we expect are actually set.
})
When("replacing a coordinator Pod", func() {
var replacedPod corev1.Pod
var useLocalitiesForExclusion bool
JustBeforeEach(func() {
initialPods := fdbCluster.GetLogPods()
coordinators := fdbstatus.GetCoordinatorsFromStatus(fdbCluster.GetStatus())
for _, pod := range initialPods.Items {
_, isCoordinator := coordinators[string(fixtures.GetProcessGroupID(pod))]
if isCoordinator {
replacedPod = pod
break
}
}
// In case that none of the log processes are coordinators
if replacedPod.Name == "" {
replacedPod = factory.RandomPickOnePod(initialPods.Items)
}
log.Println("coordinators:", coordinators, "replacedPod", replacedPod.Name)
fdbCluster.ReplacePod(replacedPod, true)
})
BeforeEach(func() {
// Until the race condition is resolved in the FDB go bindings make sure the operator is not restarted.
// See: https://github.com/apple/foundationdb/issues/11222
// We can remove this once 7.1 is the default version.
factory.DeleteChaosMeshExperimentSafe(scheduleInjectPodKill)
useLocalitiesForExclusion = fdbCluster.GetCluster().UseLocalitiesForExclusion()
})
AfterEach(func() {
Expect(fdbCluster.ClearProcessGroupsToRemove()).NotTo(HaveOccurred())
// Make sure we reset the previous behaviour.
spec := fdbCluster.GetCluster().Spec.DeepCopy()
spec.AutomationOptions.UseLocalitiesForExclusion = pointer.Bool(useLocalitiesForExclusion)
fdbCluster.UpdateClusterSpecWithSpec(spec)
Expect(fdbCluster.GetCluster().UseLocalitiesForExclusion()).To(Equal(useLocalitiesForExclusion))
// Making sure we included back all the process groups after exclusion is complete.
Expect(fdbCluster.GetStatus().Cluster.DatabaseConfiguration.ExcludedServers).To(BeEmpty())
if factory.ChaosTestsEnabled() {
scheduleInjectPodKill = factory.ScheduleInjectPodKillWithName(
fixtures.GetOperatorSelector(fdbCluster.Namespace()),
"*/2 * * * *",
chaosmesh.OneMode,
fdbCluster.Namespace()+"-"+fdbCluster.Name(),
)
}
})
When("IP addresses are used for exclusion", func() {
BeforeEach(func() {
spec := fdbCluster.GetCluster().Spec.DeepCopy()
spec.AutomationOptions.UseLocalitiesForExclusion = pointer.Bool(false)
fdbCluster.UpdateClusterSpecWithSpec(spec)
})
It("should remove the targeted Pod", func() {
fdbCluster.EnsurePodIsDeleted(replacedPod.Name)
})
})
When("localities are used for exclusion", func() {
BeforeEach(func() {
cluster := fdbCluster.GetCluster()
fdbVersion, err := fdbv1beta2.ParseFdbVersion(cluster.GetRunningVersion())
Expect(err).NotTo(HaveOccurred())
if !fdbVersion.SupportsLocalityBasedExclusions() {
Skip("provided FDB version: " + cluster.GetRunningVersion() + " doesn't support locality based exclusions")
}
spec := cluster.Spec.DeepCopy()
spec.AutomationOptions.UseLocalitiesForExclusion = pointer.Bool(true)
fdbCluster.UpdateClusterSpecWithSpec(spec)
Expect(fdbCluster.GetCluster().UseLocalitiesForExclusion()).To(BeTrue())
})
It("should remove the targeted Pod", func() {
Expect(pointer.BoolDeref(fdbCluster.GetCluster().Spec.AutomationOptions.UseLocalitiesForExclusion, false)).To(BeTrue())
fdbCluster.EnsurePodIsDeleted(replacedPod.Name)
})
})
})
When("setting storageServersPerPod", func() {
var initialStorageServerPerPod, expectedPodCnt, expectedStorageProcessesCnt int
BeforeEach(func() {
initialStorageServerPerPod = fdbCluster.GetStorageServerPerPod()
initialPods := fdbCluster.GetStoragePods()
expectedPodCnt = len(initialPods.Items)
expectedStorageProcessesCnt = expectedPodCnt * initialStorageServerPerPod
log.Printf(
"expectedPodCnt: %d, expectedStorageProcessesCnt: %d",
expectedPodCnt,
expectedStorageProcessesCnt,
)
fdbCluster.ValidateProcessesCount(fdbv1beta2.ProcessClassStorage, expectedPodCnt, expectedStorageProcessesCnt)
})
AfterEach(func() {
log.Printf("set storage server per pod to %d", initialStorageServerPerPod)
Expect(fdbCluster.SetStorageServerPerPod(initialStorageServerPerPod)).ShouldNot(HaveOccurred())
log.Printf(
"expectedPodCnt: %d, expectedStorageProcessesCnt: %d",
expectedPodCnt,
expectedPodCnt*initialStorageServerPerPod,
)
fdbCluster.ValidateProcessesCount(fdbv1beta2.ProcessClassStorage,
expectedPodCnt,
expectedPodCnt*initialStorageServerPerPod,
)
})
It("should update the storage servers to the expected amount", func() {
// Update to double the SS per Disk
serverPerPod := initialStorageServerPerPod * 2
log.Printf("set storage server per Pod to %d", serverPerPod)
Expect(fdbCluster.SetStorageServerPerPod(serverPerPod)).ShouldNot(HaveOccurred())
log.Printf(
"expectedPodCnt: %d, expectedStorageProcessesCnt: %d",
expectedPodCnt,
expectedPodCnt*serverPerPod,
)
fdbCluster.ValidateProcessesCount(fdbv1beta2.ProcessClassStorage, expectedPodCnt, expectedPodCnt*serverPerPod)
})
})
When("changing the volume size", func() {
var initialPods *corev1.PodList
var newSize, initialStorageSize resource.Quantity
BeforeEach(func() {
var err error
initialPods = fdbCluster.GetLogPods()
// We use ProcessClassGeneral here because we are not setting any specific settings for the Log processes.
initialStorageSize, err = fdbCluster.GetVolumeSize(fdbv1beta2.ProcessClassGeneral)
Expect(err).NotTo(HaveOccurred())
// Add 10G to the current size
newSize = initialStorageSize.DeepCopy()
newSize.Add(resource.MustParse("10G"))
Expect(
fdbCluster.SetVolumeSize(fdbv1beta2.ProcessClassGeneral, newSize),
).NotTo(HaveOccurred())
})
AfterEach(func() {
Expect(
fdbCluster.SetVolumeSize(fdbv1beta2.ProcessClassGeneral, initialStorageSize),
).NotTo(HaveOccurred())
})
It("should replace all the log Pods and use the new volume size", func() {
pods := fdbCluster.GetLogPods()
Expect(pods.Items).NotTo(ContainElements(initialPods.Items))
volumeClaims := fdbCluster.GetVolumeClaimsForProcesses(
fdbv1beta2.ProcessClassLog,
)
Expect(len(volumeClaims.Items)).To(Equal(len(initialPods.Items)))
for _, volumeClaim := range volumeClaims.Items {
req := volumeClaim.Spec.Resources.Requests[corev1.ResourceStorage]
Expect((&req).Value()).To(Equal(newSize.Value()))
}
})
})
When("Shrinking the number of log processes by one", func() {
var initialLogPodCount int
BeforeEach(func() {
initialLogPodCount = len(fdbCluster.GetLogPods().Items)
})
AfterEach(func() {
// Set the log process count back to the default value
Expect(fdbCluster.UpdateLogProcessCount(initialLogPodCount)).NotTo(HaveOccurred())
Eventually(func() int {
return len(fdbCluster.GetLogPods().Items)
}).Should(BeNumerically("==", initialLogPodCount))
})
It("should reduce the number of log processes by one", func() {
Expect(fdbCluster.UpdateLogProcessCount(initialLogPodCount - 1)).NotTo(HaveOccurred())
Eventually(func() int {
return len(fdbCluster.GetLogPods().Items)
}).WithTimeout(5 * time.Minute).WithPolling(1 * time.Second).Should(BeNumerically("==", initialLogPodCount-1))
})
})
When("a Pod is in a failed scheduling state", func() {
var failedPod corev1.Pod
BeforeEach(func() {
initialPods := fdbCluster.GetStatelessPods()
failedPod = factory.RandomPickOnePod(initialPods.Items)
log.Printf("Setting pod %s to unschedulable.", failedPod.Name)
fdbCluster.SetPodAsUnschedulable(failedPod)
fdbCluster.ReplacePod(failedPod, true)
})
AfterEach(func() {
Expect(fdbCluster.ClearBuggifyNoSchedule(true)).NotTo(HaveOccurred())
Expect(fdbCluster.ClearProcessGroupsToRemove()).NotTo(HaveOccurred())
})
It("should remove the targeted Pod", func() {
fdbCluster.EnsurePodIsDeletedWithCustomTimeout(failedPod.Name, 15)
})
})
When("a Pod is unscheduled and another Pod is being replaced", func() {
var failedPod *corev1.Pod
var podToReplace *corev1.Pod
BeforeEach(func() {
// We bring down two pods, which could cause some recoveries.
availabilityCheck = false
failedPod = factory.ChooseRandomPod(fdbCluster.GetStatelessPods())
podToReplace = factory.ChooseRandomPod(fdbCluster.GetStatelessPods())
log.Println(
"Failed (unscheduled) Pod:",
failedPod.Name,
", Pod to replace:",
podToReplace.Name,
)
fdbCluster.SetPodAsUnschedulable(*failedPod)
fdbCluster.ReplacePod(*podToReplace, false)
})
// 2024/11/26 01:41:00 Failed (unscheduled) Pod: operator-test-fdnhokqf-stateless-42898 , Pod to replace: operator-test-fdnhokqf-stateless-93723
AfterEach(func() {
Expect(fdbCluster.ClearBuggifyNoSchedule(false)).NotTo(HaveOccurred())
Expect(fdbCluster.ClearProcessGroupsToRemove()).NotTo(HaveOccurred())
})
It("should remove the targeted Pod", func() {
fdbCluster.EnsurePodIsDeletedWithCustomTimeout(podToReplace.Name, 15)
})
})
When("Skipping a cluster for reconciliation", func() {
var initialGeneration int64
BeforeEach(func() {
fdbCluster.SetSkipReconciliation(true)
initialGeneration = fdbCluster.GetCluster().Status.Generations.Reconciled
})
It("should not reconcile and keep the cluster in the same generation", func() {
initialStoragePods := fdbCluster.GetStoragePods()
podToDelete := factory.ChooseRandomPod(initialStoragePods)
log.Printf("deleting storage pod %s/%s", podToDelete.Namespace, podToDelete.Name)
factory.DeletePod(podToDelete)
Eventually(func() int {
return len(fdbCluster.GetStoragePods().Items)
}).WithTimeout(5 * time.Minute).WithPolling(1 * time.Second).Should(BeNumerically("==", len(initialStoragePods.Items)-1))
Consistently(func() int64 {
return fdbCluster.GetCluster().Status.Generations.Reconciled
}).WithTimeout(30 * time.Second).WithPolling(1 * time.Second).Should(BeNumerically("==", initialGeneration))
})
AfterEach(func() {
fdbCluster.SetSkipReconciliation(false)
})
})
PWhen("Changing the TLS setting", func() {
// Currently disabled until a new release of the operator is out
It("should disable or enable TLS and keep the cluster available", func() {
// Only change the TLS setting for the cluster and not for the sidecar otherwise we have to recreate
// all Pods which takes a long time since we recreate the Pods one by one.
log.Println("disable TLS for main container")
Expect(fdbCluster.SetTLS(false, true)).NotTo(HaveOccurred())
Expect(fdbCluster.HasTLSEnabled()).To(BeFalse())
log.Println("enable TLS for main container")
Expect(fdbCluster.SetTLS(true, true)).NotTo(HaveOccurred())
Expect(fdbCluster.HasTLSEnabled()).To(BeTrue())
})
})
When("changing the public IP source", func() {
It("should change the public IP source and create/delete services", func() {
log.Printf("set public IP source to %s", fdbv1beta2.PublicIPSourceService)
Expect(
fdbCluster.SetPublicIPSource(fdbv1beta2.PublicIPSourceService),
).ShouldNot(HaveOccurred())
Eventually(func() bool {
pods := fdbCluster.GetPods()
svcList := fdbCluster.GetServices()
svcMap := make(map[string]struct{}, len(svcList.Items))
for _, svc := range svcList.Items {
svcMap[svc.Name] = struct{}{}
}
for _, pod := range pods.Items {
if fdbv1beta2.PublicIPSource(
pod.Annotations[fdbv1beta2.PublicIPAnnotation],
) == fdbv1beta2.PublicIPSourcePod {
continue
}
if _, ok := svcMap[pod.Name]; !ok {
return false
}
delete(svcMap, pod.Name)
}
// We only expect one service here at the end since we run the cluster with a headless service.
if fdbCluster.HasHeadlessService() {
return len(svcMap) == 1
}
return len(svcMap) == 0
}).Should(BeTrue())
})
AfterEach(func() {
log.Printf("set public IP source to %s", fdbv1beta2.PublicIPSourcePod)
Expect(
fdbCluster.SetPublicIPSource(fdbv1beta2.PublicIPSourcePod),
).ShouldNot(HaveOccurred())
svcList := fdbCluster.GetServices()
var expectedSvcCnt int
if fdbCluster.HasHeadlessService() {
expectedSvcCnt = 1
}
Expect(len(svcList.Items)).To(BeNumerically("==", expectedSvcCnt))
})
})
When("Deleting a FDB storage Pod", func() {
var podToDelete corev1.Pod
var deleteTime time.Time
BeforeEach(func() {
podToDelete = factory.RandomPickOnePod(fdbCluster.GetStoragePods().Items)
log.Printf("deleting storage pod %s/%s", podToDelete.Namespace, podToDelete.Name)
deleteTime = time.Now()
factory.DeletePod(&podToDelete)
})
It("Should recreate the storage Pod", func() {
Eventually(func() bool {
return fdbCluster.GetPod(podToDelete.Name).CreationTimestamp.After(deleteTime)
}, 3*time.Minute, 1*time.Second).Should(BeTrue())
})
})
When("enabling automatic replacements", func() {
var exp *fixtures.ChaosMeshExperiment
var initialReplaceTime time.Duration
BeforeEach(func() {
if !factory.ChaosTestsEnabled() {
Skip("Chaos tests are skipped for the operator")
}
availabilityCheck = false
initialReplaceTime = time.Duration(pointer.IntDeref(
fdbCluster.GetClusterSpec().AutomationOptions.Replacements.FailureDetectionTimeSeconds,
90,
)) * time.Second
Expect(fdbCluster.SetAutoReplacements(true, 30*time.Second)).ShouldNot(HaveOccurred())
})
When("a Pod gets partitioned", func() {
var partitionedPod *corev1.Pod
BeforeEach(func() {
partitionedPod = factory.ChooseRandomPod(fdbCluster.GetStatelessPods())
log.Printf("partition Pod: %s", partitionedPod.Name)
exp = factory.InjectPartitionBetween(
fixtures.PodSelector(partitionedPod),
chaosmesh.PodSelectorSpec{
GenericSelectorSpec: chaosmesh.GenericSelectorSpec{
Namespaces: []string{partitionedPod.Namespace},
LabelSelectors: fdbCluster.GetCachedCluster().GetMatchLabels(),
},
},
)
// Make sure the operator picks up the changes to the environment. This is not really needed but will
// speed up the tests.
fdbCluster.ForceReconcile()
})
It("should replace the partitioned Pod", func() {
log.Printf("waiting for pod removal: %s", partitionedPod.Name)
fdbCluster.WaitForPodRemoval(partitionedPod)
exists, err := factory.DoesPodExist(*partitionedPod)
Expect(err).ShouldNot(HaveOccurred())
Expect(exists).To(BeFalse())
})
})
When("more Pods are partitioned than the automatic replacement can replace concurrently", func() {
var partitionedPods []corev1.Pod
var concurrentReplacements int
var experiments []*fixtures.ChaosMeshExperiment
creationTimestamps := map[string]metav1.Time{}
BeforeEach(func() {
concurrentReplacements = fdbCluster.GetCluster().GetMaxConcurrentAutomaticReplacements()
// Allow to replace 1 Pod concurrently
spec := fdbCluster.GetCluster().Spec.DeepCopy()
spec.AutomationOptions.Replacements.MaxConcurrentReplacements = pointer.Int(1)
fdbCluster.UpdateClusterSpecWithSpec(spec)
// Make sure we disable automatic replacements to prevent the case that the operator replaces one Pod
// before the partitioned is injected.
Expect(fdbCluster.SetAutoReplacements(false, 30*time.Second)).ShouldNot(HaveOccurred())
// Pick 2 Pods, so the operator has to replace them one after another
partitionedPods = factory.RandomPickPod(fdbCluster.GetStatelessPods().Items, 3)
for _, partitionedPod := range partitionedPods {
pod := partitionedPod
log.Printf("partition Pod: %s", pod.Name)
experiments = append(experiments, factory.InjectPartitionBetween(
fixtures.PodSelector(&pod),
chaosmesh.PodSelectorSpec{
GenericSelectorSpec: chaosmesh.GenericSelectorSpec{
Namespaces: []string{pod.Namespace},
LabelSelectors: fdbCluster.GetCachedCluster().GetMatchLabels(),
},
},
))
creationTimestamps[pod.Name] = pod.CreationTimestamp
}
// Make sure the status can settle
time.Sleep(1 * time.Minute)
// Now we can enable the replacements.
Expect(fdbCluster.SetAutoReplacements(true, 30*time.Second)).ShouldNot(HaveOccurred())
})
AfterEach(func() {
spec := fdbCluster.GetCluster().Spec.DeepCopy()
spec.AutomationOptions.Replacements.MaxConcurrentReplacements = pointer.Int(concurrentReplacements)
fdbCluster.UpdateClusterSpecWithSpec(spec)
for _, experiment := range experiments {
factory.DeleteChaosMeshExperimentSafe(experiment)
}
})
It("should replace the all partitioned Pod", func() {
Eventually(func() bool {
allUpdatedOrRemoved := true
for _, pod := range fdbCluster.GetStatelessPods().Items {
creationTime, exists := creationTimestamps[pod.Name]
// If the Pod doesn't exist we can assume it was updated.
if !exists {
continue
}
log.Println(pod.Name, "creation time map:", creationTime.String(), "creation time metadata:", pod.CreationTimestamp.String())
// The current creation timestamp of the Pod is after the initial creation
// timestamp, so the Pod was replaced.
if pod.CreationTimestamp.Compare(creationTime.Time) < 1 {
allUpdatedOrRemoved = false
}
}
return allUpdatedOrRemoved
})
})
})
When("a Pod has a bad disk", func() {
var podWithIOError corev1.Pod
BeforeEach(func() {
if !factory.ChaosTestsEnabled() {
Skip("Chaos tests are skipped for the operator")
}
availabilityCheck = false
initialPods := fdbCluster.GetStoragePods()
podWithIOError = factory.RandomPickOnePod(initialPods.Items)
log.Printf("Injecting I/O chaos to %s for 1 minute", podWithIOError.Name)
exp = factory.InjectDiskFailureWithDuration(fixtures.PodSelector(&podWithIOError), "1m")
log.Printf("iochaos injected to %s", podWithIOError.Name)
// File creation should fail due to I/O error
Eventually(func() error {
_, _, err := factory.ExecuteCmdOnPod(
context.Background(),
&podWithIOError,
fdbv1beta2.MainContainerName,
"touch /var/fdb/data/test",
false,
)
return err
}).WithTimeout(5 * time.Minute).Should(HaveOccurred())
processGroupID := string(fixtures.GetProcessGroupID(podWithIOError))
Eventually(func(g Gomega) []string {
status := fdbCluster.GetStatus()
for _, process := range status.Cluster.Processes {
processID, ok := process.Locality[fdbv1beta2.FDBLocalityInstanceIDKey]
if !ok || processID != processGroupID {
continue
}
log.Println(process.Messages)
g.Expect(len(process.Messages)).To(BeNumerically(">=", 1))
messageNames := make([]string, 0, len(process.Messages))
for _, message := range process.Messages {
messageNames = append(messageNames, message.Name)
}
log.Println(messageNames)
return messageNames
}
return nil
}).WithPolling(1 * time.Second).WithTimeout(5 * time.Minute).Should(Or(ContainElement("io_error"), ContainElement("io_timeout")))
fdbCluster.ForceReconcile()
})
It("should remove the targeted process", func() {
processGroupID := fixtures.GetProcessGroupID(podWithIOError)
// Wait until the process group is marked to be removed.
Expect(fdbCluster.WaitUntilWithForceReconcile(1, 600, func(cluster *fdbv1beta2.FoundationDBCluster) bool {
for _, processGroup := range cluster.Status.ProcessGroups {
if processGroup.ProcessGroupID != processGroupID {
continue
}
return processGroup.RemovalTimestamp != nil
}
return false
})).NotTo(HaveOccurred())
// Wait until the process group is removed
Expect(fdbCluster.WaitUntilWithForceReconcile(1, 1200, func(cluster *fdbv1beta2.FoundationDBCluster) bool {
for _, processGroup := range cluster.Status.ProcessGroups {
if processGroup.ProcessGroupID != processGroupID {
continue
}
// At this point the process group still exists.
return false
}
return true
})).NotTo(HaveOccurred())
})
})
AfterEach(func() {
Expect(fdbCluster.SetAutoReplacements(true, initialReplaceTime)).ShouldNot(HaveOccurred())
factory.DeleteChaosMeshExperimentSafe(exp)
})
})
When("a Pod has high I/O latency", func() {
var podWithIOError corev1.Pod
var exp *fixtures.ChaosMeshExperiment
BeforeEach(func() {
if !factory.ChaosTestsEnabled() {
Skip("Chaos tests are skipped for the operator")
}
availabilityCheck = false
initialPods := fdbCluster.GetLogPods()
podWithIOError = factory.RandomPickOnePod(initialPods.Items)
log.Printf("injecting iochaos to %s", podWithIOError.Name)
exp = factory.InjectIOLatency(fixtures.PodSelector(&podWithIOError), "2s")
log.Printf("iochaos injected to %s", podWithIOError.Name)
})
AfterEach(func() {
Expect(fdbCluster.ClearProcessGroupsToRemove()).NotTo(HaveOccurred())
factory.DeleteChaosMeshExperimentSafe(exp)
})
It("should remove the targeted process", func() {
fdbCluster.ReplacePod(podWithIOError, true)
fdbCluster.EnsurePodIsDeleted(podWithIOError.Name)
})
})
When("we change the process group prefix", func() {
prefix := "banana"
BeforeEach(func() {
Expect(fdbCluster.SetProcessGroupPrefix(prefix)).NotTo(HaveOccurred())
})
It("should add the prefix to all instances", func() {
lastForcedReconciliationTime := time.Now()
forceReconcileDuration := 4 * time.Minute
Eventually(func(g Gomega) bool {
// Force a reconcile if needed to make sure we speed up the reconciliation if needed.
if time.Since(lastForcedReconciliationTime) >= forceReconcileDuration {
fdbCluster.ForceReconcile()
lastForcedReconciliationTime = time.Now()
}
// Check if all process groups are migrated
for _, processGroup := range fdbCluster.GetCluster().Status.ProcessGroups {
if processGroup.IsMarkedForRemoval() && processGroup.IsExcluded() {
continue
}
g.Expect(string(processGroup.ProcessGroupID)).To(HavePrefix(prefix))
}